ci(test): Travis → Circle #671

Haroenv · 2019-04-30T11:46:30Z

config file with same setup
purging unused devDeps
purging unused scripts

Haroenv · 2019-04-30T13:55:59Z

package.json

@@ -7,19 +7,14 @@
  "scripts": {
    "watch": "watchify index.js -v -s algoliasearchHelper -o dist/algoliasearch.helper.js",
    "build": "./scripts/build.sh",
-    "dev": "DEBUG=zuul* zuul --no-coverage --local 8090 test/run.js",


these didn't work anymore since #624

Haroenv · 2019-04-30T13:56:22Z

package.json

    "lint:watch": "onchange 'src/**/*js' 'index.js' 'test/**/*js' '.eslintrc' -- npm run -s lint",
-    "open": "sleep 1 && opn http://localhost:8080/examples",
-    "examples": "npm run build & npm run open & http-server .",


these didn't work anymore since the examples moved to codepen, years ago

Haroenv · 2019-04-30T13:56:32Z

package.json

    "doc": "gulp --gulpfile documentation-src/build.gulp.js doc",
    "doc:watch": "gulp --gulpfile documentation-src/build.gulp.js doc:watch",
    "doc:publish": "yarn run doc && gh-pages -d documentation",
    "doc:staging": "scripts/staging-doc.sh",
    "readme:toc": "doctoc --notitle README.md --maxlevel 3",
    "test": "scripts/test.sh",
-    "test:ci": "scripts/test-ci.sh",


replaced by circle script

Haroenv · 2019-04-30T13:56:46Z

package.json

@@ -83,25 +75,19 @@
    "metalsmith-serve": "0.0.7",
    "metalsmith-watch": "1.0.3",
    "metalsmith-webpack": "1.0.3",
-    "mkdirp": "0.5.1",


couldn't find a usage for this

Haroenv · 2019-04-30T13:57:00Z

package.json

    "pretty-bytes-cli": "2.0.0",
    "prompt": "1.0.0",
    "pug": "^2.0.3",
-    "replace-ext": "1.0.0",
-    "rimraf": "2.6.3",


couldn't find usage of these

scripts/build.sh

Haroenv · 2019-04-30T13:57:46Z

scripts/test.sh

-
-echo "Test: lint"
-./scripts/lint.sh
+node test/run.js


I wonder if this should just be in package.json too

Haroenv · 2019-04-30T13:58:11Z

test/integration-spec/helper.distinct.facet.js

@@ -7,13 +7,9 @@ var algoliasearchHelper = utils.isCIBrowser ? window.algoliasearchHelper : requi

 var random = require('lodash/random');

-if (!utils.shouldRun) {


this util was for browser compat, which isn't possible anymore with Jest

Haroenv · 2019-04-30T13:59:27Z

test/integration-utils.js

 module.exports = {
-  isCIBrowser: process.browser && process.env.TRAVIS_BUILD_NUMBER,


this was for browser compat

scripts/build.sh

.circleci/config.yml

Co-Authored-By: Haroenv <fingebimus@me.com>

.circleci/config.yml

* ci(circle): add config file * chore(nvm): consistent version * chore(pkg): remove unused scripts & packages * ci: remove unused scripts * ci(circle): correct config * ci: also run docs * ci(circle): remove browser leftovers * ci(circle): more fitting index name * ci: replace travis build by circle build * ci: simplify scripts * remove utils.isCIBrowser * Update scripts/build.sh Co-Authored-By: Haroenv <fingebimus@me.com> * ci(circle): change naming * chore(ci): consistent naming

* 2.27.0 - 2019-04-12 4939f6f, closes #640 #646 * Update README.md 059481d * chore(build): add source map support (#654) 42ea2d5 * chore(deps): update dependency algolia-frontend-components to v0.0.35 (#605) 41043af * chore(deps): update dependency algoliasearch to v3.32.0 (#628) e5cab52 * chore(deps): update dependency babel-core to v6.26.3 (#581) 051075c * chore(deps): update dependency browserify to v14.5.0 (#582) 66e2a79 * chore(deps): update dependency handlebars to v4.1.0 (#589) bf1c493 * chore(deps): update dependency http-server to v0.11.1 (#590) 673ee5f * chore: use only yarn (no more npm 👩‍🚒) (#637) dba85a0 * chore(deps): update dependency mversion to v1.13.0 (#630) 1304f19 * chore(deps): update dependency rimraf to v2.6.3 (#596) 5e17830 * chore(deps): update st (#625) 5d7d915 * chore(docs): change jade to pug (#615) 80a20dc, closes #613 * chore(docs): fix interpolation dd888f2 * chore(docs): remove folder in (#616) 7bfc971 * chore(Jest): enable typeahead plugin (#668) 029e11c * chore(Jest): setup migration (#659) 2bf5e10 * chore(Travis): build all branches (#669) bc2eb18 * ci(test): Travis → Circle (#671) 2442ab0 * docs(init): use toggleFacetRefinement instead (#622) 2461ffe * docs(instantiate): use existing signature of toggleRefine (#621) 6be5ec1 * docs: fix InstantSearch link (#640) 2c97a71, closes #640 * docs: fix typo on hierarchical facets (#646) ee5b3b4, closes #646 * feat(sffv): throw an error if it's called and the client doesn't have the functions (#623) dd61360 * fix(ua): change the User-Agent to use the new specs lib (version) (#647) eafd4cf * refactor(events): replace util.inherits by inline (#653) 16459ae * test(client): update index name (#619) 3564274

* ci(circle): add config file * chore(nvm): consistent version * chore(pkg): remove unused scripts & packages * ci: remove unused scripts * ci(circle): correct config * ci: also run docs * ci(circle): remove browser leftovers * ci(circle): more fitting index name * ci: replace travis build by circle build * ci: simplify scripts * remove utils.isCIBrowser * Update scripts/build.sh Co-Authored-By: Haroenv <fingebimus@me.com> * ci(circle): change naming * chore(ci): consistent naming

Haroenv added 4 commits April 30, 2019 13:42

ci(circle): add config file

d978227

chore(nvm): consistent version

ae27246

chore(pkg): remove unused scripts & packages

0315fc7

ci: remove unused scripts

235251b

Haroenv added the PR: do not merge label Apr 30, 2019

Haroenv added 6 commits April 30, 2019 13:47

ci(circle): correct config

7673b07

ci: also run docs

20f6880

ci(circle): remove browser leftovers

b5d924f

ci(circle): more fitting index name

8771ac2

ci: replace travis build by circle build

15e5430

ci: simplify scripts

6b3b5ba

Haroenv removed the PR: do not merge label Apr 30, 2019

Haroenv requested a review from a team April 30, 2019 12:29

remove utils.isCIBrowser

fa77e70

Haroenv commented Apr 30, 2019

View reviewed changes

samouss suggested changes Apr 30, 2019

View reviewed changes

scripts/build.sh Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

samouss and others added 2 commits April 30, 2019 16:13

Update scripts/build.sh

bfe58ca

Co-Authored-By: Haroenv <fingebimus@me.com>

ci(circle): change naming

a1fabc7

Haroenv requested review from samouss and francoischalifour April 30, 2019 16:27

samouss approved these changes May 2, 2019

View reviewed changes

samouss reviewed May 2, 2019

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

chore(ci): consistent naming

c93ef1d

Haroenv merged commit 5837dfd into develop May 2, 2019

Haroenv deleted the ci/circle branch May 2, 2019 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(test): Travis → Circle #671

ci(test): Travis → Circle #671

Haroenv commented Apr 30, 2019

Haroenv Apr 30, 2019

Haroenv Apr 30, 2019

Haroenv Apr 30, 2019

Haroenv Apr 30, 2019

Haroenv Apr 30, 2019

Haroenv Apr 30, 2019

Haroenv Apr 30, 2019

Haroenv Apr 30, 2019

		@@ -7,13 +7,9 @@ var algoliasearchHelper = utils.isCIBrowser ? window.algoliasearchHelper : requi

		var random = require('lodash/random');

		if (!utils.shouldRun) {

		module.exports = {
		isCIBrowser: process.browser && process.env.TRAVIS_BUILD_NUMBER,

ci(test): Travis → Circle #671

ci(test): Travis → Circle #671

Conversation

Haroenv commented Apr 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment