Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/2799 Remove redundant behaviour and improve intellisense #84

Merged
merged 13 commits into from
Apr 4, 2022

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Mar 23, 2022

fixes adaptlearning/adapt_framework#2957
fixes adaptlearning/adapt_framework#2799
helps with adaptlearning/adapt_framework#3009

This should improve vscode intellisense substantially whilst helping us better define and utilise current Adapt APIs.

Moved

  • Adapt.register, Adapt.getModelName, Adapt.getModelClass, Adapt.getViewName and Adapt.getViewClass functions and Adapt.store property in to core/js/components
  • Adapt.location property to core/js/location with jsdocs for the available properties
  • Some deprecated Adapt.wait behaviour into core/js/deprecated
  • Various bits of behaviour into their relevant modules (startController execution, etc)

Removed

  • Interim CSS fix from scriptLoader

Deprecated

These now have console warnings about being deprecated

  • Adapt.a11y for core/js/a11y
  • Adapt.componentStore for core/js/components
  • Adapt.data for core/js/data
  • Adapt.device for core/js/device
  • Adapt.drawer for core/js/drawer
  • Adapt.location for core/js/location
  • Adapt.notify for core/js/notify
  • Adapt.offlineStorage for core/js/offlineStorage
  • Adapt.router for core/js/router
  • Adapt.startController for core/js/startController
  • Adapt.scrolling for core/js/scrolling
  • Adapt.store for core/js/components
  • Adapt.tracking for core/js/tracking
  • Adapt.navigateToElement for core/js/router equivalent
  • Adapt.register for core/js/components equivalent
  • Adapt.getViewName for core/js/components equivalent
  • Adapt.getViewClass for core/js/components equivalent
  • Adapt.getModelName for core/js/components equivalent
  • Adapt.getModelClass for core/js/components equivalent
  • Adapt.findById for core/js/data equivalent
  • Adapt.findViewByModelId for core/js/data equivalent
  • Adapt.findByTrackingPosition for core/js/data equivalent

Changed

  • jsx html() for dangerouslySetInnerHtml
  • Referenced all modules directly

Fixed

  • Circular dependencies in a11y files and folders
  • Circular dependencies in router, AdaptModel, ContentObjectModel and CourseModel
  • Circular dependencies in router and startController
  • Linting errors

@oliverfoster oliverfoster added the bug Something isn't working label Mar 23, 2022
@oliverfoster oliverfoster self-assigned this Mar 23, 2022
@oliverfoster oliverfoster changed the title issue/2799 issue/2799 Remove redundant behaviour and improve intellisense Mar 23, 2022
This was referenced Mar 23, 2022
js/adapt.js Outdated Show resolved Hide resolved
js/adapt.js Outdated Show resolved Hide resolved
js/adapt.js Outdated Show resolved Hide resolved
js/adapt.js Outdated Show resolved Hide resolved
js/adapt.js Outdated Show resolved Hide resolved
js/components.js Outdated Show resolved Hide resolved
js/data.js Outdated Show resolved Hide resolved
js/components.js Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

@lc-alexanderbenesch lc-alexanderbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 9c80622 into master Apr 4, 2022
@oliverfoster oliverfoster deleted the issue/2799 branch April 4, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants