Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt_framework: Move from a central extended singleton to imported singletons #3009

Closed
oliverfoster opened this issue Jan 7, 2021 · 1 comment
Closed

adapt_framework: Move from a central extended singleton to imported singletons #3009

oliverfoster opened this issue Jan 7, 2021 · 1 comment
Assignees
@eleanor-heath
Labels
enhancement

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jan 7, 2021 •
edited
Loading

Subject of the issue

Adapt.device and Adapt.a11y style APIs do not work well with intellisense as there are not defined on the Adapt object in core/js/adapt but are instead injected from core/js/device or core/js/a11y respectively. It would be better to deprecate Adapt.device style APIs in favour of import device from 'core/js/device'; or import a11y from 'core/js/a11y'; wherefrom intellisense would work perfectly.
@oliverfoster oliverfoster mentioned this issue Jul 29, 2021
Merged
@eleanor-heath eleanor-heath self-assigned this Nov 29, 2021
This was referenced Mar 9, 2022
Closed
Merged
Closed
Merged
This was referenced Mar 16, 2022
Merged
Merged
Merged
Merged
@oliverfoster oliverfoster mentioned this issue Mar 23, 2022
Merged
@eleanor-heath eleanor-heath mentioned this issue Apr 6, 2022
Closed
@oliverfoster
Copy link
Member Author

fixed with works for #2799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleanor-heath eleanor-heath

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliverfoster @eleanor-heath