Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAPT-9790 - import a11y and device singletons #223

Merged
merged 1 commit into from
Mar 28, 2022
Merged

ADAPT-9790 - import a11y and device singletons #223

merged 1 commit into from
Mar 28, 2022

Conversation

eleanor-heath
Copy link
Contributor

@eleanor-heath eleanor-heath self-assigned this Mar 9, 2022
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with v5.19.0, all working as it should.

@oliverfoster oliverfoster merged commit 13e78ef into master Mar 28, 2022
@oliverfoster oliverfoster deleted the 9790-move-from-central-extended-singleton branch March 28, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@chris-steele chris-steele Awaiting requested review from chris-steele

@danielghost danielghost Awaiting requested review from danielghost

@lc-alexanderbenesch lc-alexanderbenesch Awaiting requested review from lc-alexanderbenesch

Assignees

@eleanor-heath eleanor-heath

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eleanor-heath @oliverfoster @cahirodoherty-learningpool @joe-allen-89