Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/2799 Remove redundant behaviour #230

Merged
merged 2 commits into from
Apr 29, 2022
Merged

issue/2799 Remove redundant behaviour #230

merged 2 commits into from
Apr 29, 2022

Conversation

oliverfoster
Copy link
Member

requires adaptlearning/adapt-contrib-core#84
part of adaptlearning/adapt_framework#2799

Changed

  • Use offlineStorage, data, logging and notify directly
  • Linting issues

@oliverfoster oliverfoster self-assigned this Mar 24, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with FW v5.19.2 both locally and on test site, working as expected on both.

@joe-allen-89 joe-allen-89 merged commit 70b465f into master Apr 29, 2022
@joe-allen-89 joe-allen-89 deleted the issue/2799 branch April 29, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants