Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/2799 Remove redundant behaviour #59

Merged
merged 3 commits into from
Apr 11, 2022
Merged

issue/2799 Remove redundant behaviour #59

merged 3 commits into from
Apr 11, 2022

Conversation

oliverfoster
Copy link
Member

requires adaptlearning/adapt-contrib-core#84
part of adaptlearning/adapt_framework#2799

Changed

  • Use offlineStorage, a11y, logging, router, data and notify directly

@oliverfoster oliverfoster self-assigned this Mar 24, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

@lc-alexanderbenesch lc-alexanderbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eleanor-heath
Copy link
Contributor

there are conflicts in the branch that need resolved

@oliverfoster
Copy link
Member Author

await merge and release of adaptlearning/adapt-contrib-core#84

@oliverfoster oliverfoster merged commit e2fb537 into master Apr 11, 2022
@oliverfoster oliverfoster deleted the issue/2799 branch April 11, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants