sync of dev/gfdl with master #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cing the necessary functions with fms2_io_mod functions
…name when needed and removing unneccessary code in fv_io_mod
…, addressding Uriel's comments from PR#74
…ter_axis in fv_ada_nudge. Reintroducing flush function and updating namelist read in fv_diag_column
…ation Fms2 io implementation
Adding Issue Templates to Repository
…er resolving merge conflicts
Dev/gfdl updates being brought back to master
Formatted PDF and source files for FV3 documentation.
FV3 Documentation
Revision 1.0a
Updated defaults for hord options to use 8 and 10, and removal of mention of hord = 9, which is now a different (experimental, unsupported) scheme.
Adding Code Style guide to the repository.
…fixes Typo fix in fv_io.F90
*Corrected* update to FV3 documentation v1.0a
Documentation and defaults changes
(cherry picked from commit bf0630f)
…ion (NOAA-GFDL#114) * merge of latest dev work from GFDL Weather and Climate Dynamics Division * remove trailing whitespace from source files * release notes updates in RELEASE.md * Remove blocks of debug code and commented code
* read ak/bk from user specified files * add input.nml parameter fv_eta_file for user specified ak/bk; change ks calculation when npz_type=input; use newunit to replace fixed file unit for npz_type=input (cherry picked from commit 3a0d35a) Conflicts: model/fv_control.F90 tools/fv_eta.F90
* Create examples README.md * Reorganizing files in docs/ directory * Added advection notebook * Fixed subplot spacing * New 3D case notebooks * Added notebooks * Update README.md
* add check on eta levels to ensure their monotonicity * update Jili Dong's ak/bk external input to - use the FMS ascii_read (single read/broadcast) - error check input to ensure the proper number of levels present * added a format description for the external eta file and ensured a correct the file length check for FMS 2021.03 and greater
…n (20210804) (NOAA-GFDL#127) * output conversion error warning in debug mode w/ Intel * incorrect argument to mpp_max in fv_restart.F90 affecting nesting
…ow hydrostatic ICs
Makes the non-hydrostatic restart variables optional for reads to allow hydrostatic IC
bensonr
requested review from
lharris4,
uramirez8707 and
thomas-robinson
and removed request for
uramirez8707
lharris4
approved these changes
Aug 31, 2021
| @@ -878,6 +879,11 @@ module fv_arrays_mod | |||
|
|
|||
| integer :: bc_update_interval = 3 !< Default setting for interval (hours) between external regional BC data files. | |||
|
|
|||
| integer :: nrows_blend = 0 !< # of blending rows in the outer integration domain. | |||
There was a problem hiding this comment.
These updates allow the climate models to be run as RCMs.
| @@ -203,16 +206,12 @@ subroutine get_external_ic( Atm, fv_domain, cold_start ) | |||
| call prt_maxmin('graupel', Atm%q(:,:,:,graupel), is, ie, js, je, ng, Atm%npz, 1.) | |||
| if ( o3mr > 0 ) & | |||
| call prt_maxmin('O3MR', Atm%q(:,:,:,o3mr), is, ie, js, je, ng, Atm%npz, 1.) | |||
| if ( sgs_tke > 0 ) & | |||
There was a problem hiding this comment.
Maybe later we should just cycle through all the tracer species instead of hard-coding each one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Synchronize the latest public release in master with dev/gfdl branch. This update fixes nesting bugs, introduces regional capabilities, as well as advanced nesting capabilities (multiple and telescoping nests).
Includes a fix for #134
How Has This Been Tested?
This release has been extensively tested in the SHiELD models and with the UFS. Prior to merge, tests will be completed with GFDL models.
Checklist:
Please check all whether they apply or not