Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FV3 Example Notebooks and cleanup of docs directory #117

Merged
merged 15 commits into from
Jul 21, 2021

Conversation

lharris4
Copy link
Contributor

Description

Introduces example solo_core notebooks and moves source for FV3 documentation into its own directory. We are hoping to greatly expand the examples library in the future to show just how FV3 can be put to work.

Fixes # (issue)

How Has This Been Tested?

Notebooks are viewable in the browser.

Checklist:

Please check all whether they apply or not

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [x ] Any dependent changes have been merged and published in downstream modules

@bensonr bensonr merged commit ef5028f into NOAA-GFDL:master Jul 21, 2021
bensonr added a commit that referenced this pull request Aug 27, 2021
* Removing use of mpp_io_mod and fms_io_mod from the dycore code.  Replacing the necessary functions with fms2_io_mod functions

* Adding a call to set_filename_appendix so that nest is added to filename when needed and removing unneccessary code in fv_io_mod

* FV3 Documentation - formatted PDF and source files for FV3 documentation.

* Documentation and defaults changes
 - Updated defaults for hord options to use 8 and 10, and removal of mention of hord = 9 (experimental, unsupported) scheme.

* Initialize {sw,se,nw,ne}_corner to .false in model/fv_arrays.F90
(cherry picked from commit bf0630f)

* merge of latest dev work from GFDL Weather and Climate Dynamics Division (#114)

* read ak/bk from user specified files (#115)

* add input.nml parameter fv_eta_file for user specified ak/bk; change ks calculation when npz_type=input; use newunit to replace fixed file unit for npz_type=input
(cherry picked from commit 3a0d35a)

* FV3 Example Notebooks and cleanup of docs directory (#117)

* removed module use of INPUT_STR_LENGTH in fv_control.F90 (#122)

* add check on eta levels to ensure their monotonicity

* update Jili Dong's ak/bk external input to
  - use the FMS ascii_read (single read/broadcast)
  - error check input to ensure the proper number of levels present

* added a format description for the external eta file and ensured a correct the file length check for FMS 2021.03 and greater

* merge of minor updates from GFDL Weather and Climate Dynamics Division (20210804) (#127)

Co-authored-by: Lauren Chilutti <Lauren.Chilutti@noaa.gov>
Co-authored-by: laurenchilutti <60401591+laurenchilutti@users.noreply.github.com>
Co-authored-by: lharris4 <53020884+lharris4@users.noreply.github.com>
Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Co-authored-by: Jili Dong <jili.dong@noaa.gov>
bensonr added a commit that referenced this pull request Sep 9, 2021
* Removing use of mpp_io_mod and fms_io_mod from the dycore code.  Replacing the necessary functions with fms2_io_mod functions

* Adding a call to set_filename_appendix so that nest is added to filename when needed and removing unneccessary code in fv_io_mod

* Updating dimension string arrays to address GNU compilation errors.

* correcting some typos, addressing comments from PR#74

* Adding Issue Templates

* Adding Code Style guide to the repository.

* FV3 Documentation
 - Formatted PDF and source files for FV3 documentation.
 - Revision 1.0a

* Updated defaults for hord options to use 8 and 10, and removal of mention of hord = 9, which is now a different (experimental, unsupported) scheme.

* Initialize {sw,se,nw,ne}_corner to .false in model/fv_arrays.F90
(cherry picked from commit bf0630f)

* merge of latest dev work from GFDL Weather and Climate Dynamics Division (#114)

* release notes updates in RELEASE.md

* Update README.md

* read ak/bk from user specified files (#115)

* add input.nml parameter fv_eta_file for user specified ak/bk; change ks calculation when npz_type=input; use newunit to replace fixed file unit for npz_type=input
(cherry picked from commit 3a0d35a)

* FV3 Example Notebooks and cleanup of docs directory (#117)

* removed module use of INPUT_STR_LENGTH in fv_control.F90 (#122)

* updates logic for file read of eta levels (#124)

* add check on eta levels to ensure their monotonicity

* update Jili Dong's ak/bk external input to
  - use the FMS ascii_read (single read/broadcast)
  - error check input to ensure the proper number of levels present

* merge of minor updates from GFDL Weather and Climate Dynamics Division (20210804) (#127)

* output conversion error warning in debug mode w/ Intel

* Makes the non-hydrostatic restart variables optional for reads to allow hydrostatic ICs

Co-authored-by: Lauren Chilutti <Lauren.Chilutti@noaa.gov>
Co-authored-by: laurenchilutti <60401591+laurenchilutti@users.noreply.github.com>
Co-authored-by: lharris4 <53020884+lharris4@users.noreply.github.com>
Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Co-authored-by: Jili Dong <jili.dong@noaa.gov>
Co-authored-by: Tom Robinson <thomas.robinson@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants