merge of latest dev work from GFDL Weather and Climate Dynamics Division #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing - need to fix a few things... |
|
@bensonr looks good to me as well |
bensonr
added a commit
that referenced
this pull request
Aug 27, 2021
* Removing use of mpp_io_mod and fms_io_mod from the dycore code. Replacing the necessary functions with fms2_io_mod functions
* Adding a call to set_filename_appendix so that nest is added to filename when needed and removing unneccessary code in fv_io_mod
* FV3 Documentation - formatted PDF and source files for FV3 documentation.
* Documentation and defaults changes
- Updated defaults for hord options to use 8 and 10, and removal of mention of hord = 9 (experimental, unsupported) scheme.
* Initialize {sw,se,nw,ne}_corner to .false in model/fv_arrays.F90
(cherry picked from commit bf0630f)
* merge of latest dev work from GFDL Weather and Climate Dynamics Division (#114)
* read ak/bk from user specified files (#115)
* add input.nml parameter fv_eta_file for user specified ak/bk; change ks calculation when npz_type=input; use newunit to replace fixed file unit for npz_type=input
(cherry picked from commit 3a0d35a)
* FV3 Example Notebooks and cleanup of docs directory (#117)
* removed module use of INPUT_STR_LENGTH in fv_control.F90 (#122)
* add check on eta levels to ensure their monotonicity
* update Jili Dong's ak/bk external input to
- use the FMS ascii_read (single read/broadcast)
- error check input to ensure the proper number of levels present
* added a format description for the external eta file and ensured a correct the file length check for FMS 2021.03 and greater
* merge of minor updates from GFDL Weather and Climate Dynamics Division (20210804) (#127)
Co-authored-by: Lauren Chilutti <Lauren.Chilutti@noaa.gov>
Co-authored-by: laurenchilutti <60401591+laurenchilutti@users.noreply.github.com>
Co-authored-by: lharris4 <53020884+lharris4@users.noreply.github.com>
Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Co-authored-by: Jili Dong <jili.dong@noaa.gov>
bensonr
added a commit
that referenced
this pull request
Sep 9, 2021
* Removing use of mpp_io_mod and fms_io_mod from the dycore code. Replacing the necessary functions with fms2_io_mod functions
* Adding a call to set_filename_appendix so that nest is added to filename when needed and removing unneccessary code in fv_io_mod
* Updating dimension string arrays to address GNU compilation errors.
* correcting some typos, addressing comments from PR#74
* Adding Issue Templates
* Adding Code Style guide to the repository.
* FV3 Documentation
- Formatted PDF and source files for FV3 documentation.
- Revision 1.0a
* Updated defaults for hord options to use 8 and 10, and removal of mention of hord = 9, which is now a different (experimental, unsupported) scheme.
* Initialize {sw,se,nw,ne}_corner to .false in model/fv_arrays.F90
(cherry picked from commit bf0630f)
* merge of latest dev work from GFDL Weather and Climate Dynamics Division (#114)
* release notes updates in RELEASE.md
* Update README.md
* read ak/bk from user specified files (#115)
* add input.nml parameter fv_eta_file for user specified ak/bk; change ks calculation when npz_type=input; use newunit to replace fixed file unit for npz_type=input
(cherry picked from commit 3a0d35a)
* FV3 Example Notebooks and cleanup of docs directory (#117)
* removed module use of INPUT_STR_LENGTH in fv_control.F90 (#122)
* updates logic for file read of eta levels (#124)
* add check on eta levels to ensure their monotonicity
* update Jili Dong's ak/bk external input to
- use the FMS ascii_read (single read/broadcast)
- error check input to ensure the proper number of levels present
* merge of minor updates from GFDL Weather and Climate Dynamics Division (20210804) (#127)
* output conversion error warning in debug mode w/ Intel
* Makes the non-hydrostatic restart variables optional for reads to allow hydrostatic ICs
Co-authored-by: Lauren Chilutti <Lauren.Chilutti@noaa.gov>
Co-authored-by: laurenchilutti <60401591+laurenchilutti@users.noreply.github.com>
Co-authored-by: lharris4 <53020884+lharris4@users.noreply.github.com>
Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Co-authored-by: Jili Dong <jili.dong@noaa.gov>
Co-authored-by: Tom Robinson <thomas.robinson@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brings in development at GFDL to enable nests in regional grids. Fixes reproducibility for global+nests pathological cases uncovered during advanced testing for reproducibility. Replaces mpp_io/fms_io with the updated fms2_io functionality now available in FMS. This update requires FMS v2021.02
Fixes # (issue)
How Has This Been Tested?
SHiELD tests were run to ensure absolute reproducibility for global, global+nests, regional, and regional+nests
Checklist:
Please check all whether they apply or not