-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SourceSetViewHelperTrait encodes image URI twice #1512
Comments
luzat
added a commit
to luzat/vhs
that referenced
this issue
Aug 29, 2018
This was referenced Aug 29, 2018
luzat
referenced
this issue
Jul 3, 2019
Removed in 9af62c4 |
|
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using images containing umlauts (e.g.
zubehör.jpg
) withv:media.image
andsrcset
thesrc
is set correctly, but insrcset
the file name is double-encoded, that isö
=>%C3%B6
=>%25C3%25B6
. It seems that this happens because of this line in SourceSetViewHelperTrait.php:static::preprocessSourceUri
encodes the string as doesGeneralUtility::rawUrlEncodeFP
. Just changing the line togets rid of a deprecated call and outputs both
src
andsrcset
correctly with%C3%B6
.The text was updated successfully, but these errors were encountered: