Skip to content

Commit

Permalink
[BUGFIX] Remove call to deprecated method
Browse files Browse the repository at this point in the history 
Close: #1570
  • Loading branch information
@NamelessCoder
NamelessCoder committed Apr 22, 2019
1 parent a8436b7 commit 9af62c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Classes/Traits/SourceSetViewHelperTrait.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function addSourceSet($tag, $src)
$srcsetVariant = $this->getImgResource($src, $width, $format, $quality, $treatIdAsReference, null, $crop);

$srcsetVariantSrc = rawurldecode($srcsetVariant[3]);
$srcsetVariantSrc = static::preprocessSourceUri(GeneralUtility::rawUrlEncodeFP($srcsetVariantSrc), $this->arguments);
$srcsetVariantSrc = static::preprocessSourceUri(str_replace('%2F', '/', rawurlencode($srcsetVariantSrc)), $this->arguments);

$imageSources[$srcsetVariant[0]] = [
'src' => $srcsetVariantSrc,
Expand Down

2 comments on commit 9af62c4

@luzat
Copy link
Contributor

@luzat luzat commented on 9af62c4 Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why this is necessary at all. Literally the same encoding is don e again within AbstractMediaHelper::preprocessSourceUri, which leads to double encoding as mentioned in #1512 and (by now outdated) PR #1513. This does for example lead to Umlauts in srcsets being double-encoded and broken. No chance to get this fixed after almost a year? :-/

@liayn
Copy link
Contributor

@liayn liayn commented on 9af62c4 Jun 26, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues related to this line currently:
#1512 #1674 #1873 #1887

Please sign in to comment.