-
Notifications
You must be signed in to change notification settings - Fork 229
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX] Remove call to deprecated method
Close: #1570
- Loading branch information
1 parent
a8436b7
commit 9af62c4
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9af62c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get why this is necessary at all. Literally the same encoding is don e again within AbstractMediaHelper::preprocessSourceUri, which leads to double encoding as mentioned in #1512 and (by now outdated) PR #1513. This does for example lead to Umlauts in srcsets being double-encoded and broken. No chance to get this fixed after almost a year? :-/
9af62c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All issues related to this line currently:
#1512 #1674 #1873 #1887