Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Image Srcset wrong url encoding #1887

Open
siwa-pparzer opened this issue Nov 9, 2023 · 3 comments
Open

BUG: Image Srcset wrong url encoding #1887

siwa-pparzer opened this issue Nov 9, 2023 · 3 comments

Comments

@siwa-pparzer
Copy link

https://github.com/FluidTYPO3/vhs/blob/development/Classes/Traits/SourceSetViewHelperTrait.php

images with special characters gets double encoded

src:
/fileadmin/processed/1/c/csm_X90_Zug_%C3%B6ffentlicher_Verkehr_train-0b8e8c69_bb8b2bd812.jpg
generated srcset:
/fileadmin/processed/1/c/csm_X90_Zug_%25C3%25B6ffentlicher_Verkehr_train-0b8e8c69_bb8b2bd812.jpg

the % character is encoded to %25

can be solved via following statement in line 60
$srcsetVariantSrc = str_replace('%25', '%', $srcsetVariantSrc);

@liayn
Copy link
Contributor

liayn commented Nov 14, 2023

duplicate of #1674 ?

@luzat
Copy link
Contributor

luzat commented Jun 19, 2024

It's still possible to apply my simple (updated) PR #1513, possibly using composer-patches or just using your own patch. Given that src was handled correctly, this just seems to be an unfixed encoding bug in this place.

@liayn
Copy link
Contributor

liayn commented Jun 26, 2024

Related issues #1512 #1674 #1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants