-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call to undefined method TYPO3\CMS\Core\Utility\GeneralUtility::rawUrlEncodeFP() #1570
Comments
TYPO3 removed this method in version 9. File: typo3/sysext/core/Classes/Utility/GeneralUtility.php in Typo3 version 8 /**
* rawurlencode which preserves "/" chars
* Useful when file paths should keep the "/" chars, but have all other special chars encoded.
*
* @param string $str Input string
* @return string Output string
* @deprecated since TYPO3 v8, will be removed in TYPO3 v9, use the PHP methods directly instead
*/
public static function rawUrlEncodeFP($str)
{
static::logDeprecatedFunction();
return str_replace('%2F', '/', rawurlencode($str));
} vhs didn't replaced it. File: Classes/Traits/SourceSetViewHelperTrait.php in vhs version 5.1.1 (and 5.2.0 too) public function addSourceSet($tag, $src)
{
// ...
$srcsetVariantSrc = rawurldecode($srcsetVariant[3]);
$srcsetVariantSrc = static::preprocessSourceUri(GeneralUtility::rawUrlEncodeFP($srcsetVariantSrc), $this->arguments);
// ...
} |
Why do you consider this as closed? the PR is not merged yet. |
@NamelessCoder sorry, i'm confused, but i still see the error: and about the PR i was mentioning is about this: 9af62c4 that code i don't see it in version 5.2.0 |
@davdenic It is solved and merged (there are no more calls to the mentioned method at all in VHS) but not yet released. Until the next release is made you can use the |
Hi @NamelessCoder do you know if the new release will happen soon? |
@davdenic Today! ;) |
Example image render
`<v:media.image
maxW="{data.imagewidth}"
treatIdAsReference="1"
title="{file.title}"
alt="{file.alternative}"
src="{file}"
class="img-responsive"
srcset="{320,480,768,992,1200}"
srcsetDefault="698"
additionalAttributes="{sizes: '(max-width: 992px) 50vw, 100vw'}"
/>`
Error Call to undefined method TYPO3\CMS\Core\Utility\GeneralUtility::rawUrlEncodeFP()
Typo3 version : 9.5.4
Vhs version :5.1.1
The text was updated successfully, but these errors were encountered: