[Refactor] Use `CloseAccount` to replace `User_Delete` and refactor related pages #9635

Beamanator · 2022-06-30T13:31:14Z

cc @Julesssss since you worked on the Close Account project

~~Holding on related Web-E PR: https://github.com/Expensify/Web-Expensify/pull/34159~~

~~Also holding on React-native-onyx version bump issue: https://github.com/Expensify/Expensify/issues/217767~~

Details

See fixed issue for design doc ref

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/213701

Tests (both Dev & Staging)

Same as mentioned in https://github.com/Expensify/Web-Expensify/pull/34159

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

Screenshots

Web & Desktop

VidCloseAccount.mov

Mobile Web

iOS

Android

melvin-bot · 2022-06-30T13:31:20Z

Looks like you modified deprecatedAPI.js! To be clear, you should not be adding any code to this file.

Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands.

Unsure if your change is okay? Drop a note in #expensify-open-source!

Beamanator · 2022-06-30T16:35:31Z

One problem to solve before marking ready for review: https://expensify.slack.com/archives/C02HWMSMZEC/p1656604993085699

…serDelete

marcaaron

This LGTM

src/ONYXKEYS.js

src/libs/actions/User.js

…serDelete

Beamanator · 2022-07-04T14:12:47Z

Thanks for the reviews so far gents! Comments addressed 👍

…serDelete

Beamanator · 2022-07-08T16:25:38Z

Needs an Onyx version bump before it will test well 👍

Beamanator · 2022-07-18T15:16:13Z

Please feel free to review with your morning coffee :)

marcaaron · 2022-07-19T05:48:48Z

Looks great, thanks for the changes and discussion 🙇

Julesssss · 2022-07-19T08:41:52Z

package-lock.json

-      "integrity": "sha1-BqZgTWpV1L9BqaR9mHLXp42jHnM="
+      "integrity": "sha512-xpkr6sCDIYTPqzvjG8M3ncw1YOTaloWZOyrUmicoEifBEKzQzt+ooUpRpQ/AbOoJfO/p2ZKiyp79qHThzJDulQ=="
    },


@Beamanator are you on an older MBP? I think we agreed to stop commiting these changes unless you have an M1 MMP

Oh interesting! I must have missed that - I'm on an Intel still, my M1 will be arriving during offshore 😅

I'll remove these unnecessary edits, thanks for calling this out

Julesssss

Left one question, but looking good

Beamanator · 2022-07-19T09:52:31Z

Updated @Julesssss 👍

Beamanator · 2022-07-29T12:16:43Z

wtf I didn't notice this didn't get merged 🙃 I'll fix conflicts today

…serDelete

Beamanator · 2022-07-29T12:36:48Z

Conflicts fixed, got 2 previous approvals so if anyone wants to approve again we can merge

src/libs/actions/CloseAccount.js

src/libs/actions/User.js

Julesssss · 2022-08-01T13:57:04Z

Still testing well:

Prevented from closing

Closed and data is cleared

OSBotify · 2022-08-01T14:04:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-08-01T22:38:57Z

🚀 Deployed to staging by @Julesssss in version: 1.1.87-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2022-08-04T20:51:00Z

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2022-10-05T19:13:47Z

src/pages/settings/Security/CloseAccountPage.js

-            initWithStoredValues: false,
+        closeAccount: {
+            key: ONYXKEYS.CLOSE_ACCOUNT,
+            initWithStoredValues: {error: '', isLoading: false},


This is actually expecting a boolean and not the values

https://github.com/Expensify/react-native-onyx/blob/main/API.md#connectmapping--number

ohhhhh interesting, good catch. It looks like in that repo we default initWithStoredValues to true so I think I can pretty much just delete this line - we do actually want to load the page with the error / loading state stored

Beamanator added 3 commits June 30, 2022 15:26

New onyx key for multiple types of close account data

c50bcb4

Replace User_Delete with CloseAccount

9dfaa32

Update close account page and action

4345f96

Beamanator self-assigned this Jun 30, 2022

Beamanator added 5 commits June 30, 2022 16:49

Remove old command

77c6728

Clean up some props and proptypes

4970ab6

Clean up imports & close account data

3eca6e3

Account for empty close account data

7a2a794

Lint: Prefer default export

bb9e58b

Merge branch 'main' of github.com:Expensify/App into beaman-refactorU…

2c2c07e

…serDelete

Beamanator marked this pull request as ready for review July 1, 2022 15:39

Beamanator requested a review from a team as a code owner July 1, 2022 15:39

Beamanator requested review from a team and removed request for a team July 1, 2022 15:39

melvin-bot bot requested review from youssef-lr and removed request for a team July 1, 2022 15:39

Beamanator added 2 commits July 1, 2022 17:41

Make one-function action work better

5466d2a

Paging dr Spacey...

587b68c

marcaaron reviewed Jul 1, 2022

View reviewed changes

src/ONYXKEYS.js Outdated Show resolved Hide resolved

Julesssss reviewed Jul 1, 2022

View reviewed changes

src/libs/actions/User.js Show resolved Hide resolved

Beamanator added 3 commits July 4, 2022 15:59

Merge branch 'main' of github.com:Expensify/App into beaman-refactorU…

8f9d9f6

…serDelete

Remove redundant 'data' in onyx key suffix

fed23a9

Remove unused translation

46cc5b1

Merge branch 'main' of github.com:Expensify/App into beaman-refactorU…

3d39f40

…serDelete

Beamanator mentioned this pull request Jul 8, 2022

Allow clear in onyx update Expensify/react-native-onyx#156

Merged

Clear onyx data on closeAccount success

8a32a15

marcaaron previously approved these changes Jul 19, 2022

View reviewed changes

Julesssss reviewed Jul 19, 2022

View reviewed changes

Julesssss previously approved these changes Jul 19, 2022

View reviewed changes

Revert unnecessary package-lock changes

200e5a8

Beamanator dismissed stale reviews from Julesssss and marcaaron via 200e5a8 July 19, 2022 09:51

Julesssss previously approved these changes Jul 19, 2022

View reviewed changes

Beamanator mentioned this pull request Jul 21, 2022

Refactor Get_ReportHistory #9613

Merged

88 tasks

Merge branch 'main' of github.com:Expensify/App into beaman-refactorU…

5c6cb1c

…serDelete

Beamanator dismissed Julesssss’s stale review via 5c6cb1c July 29, 2022 12:35

Julesssss reviewed Aug 1, 2022

View reviewed changes

src/libs/actions/CloseAccount.js Show resolved Hide resolved

Julesssss reviewed Aug 1, 2022

View reviewed changes

src/libs/actions/User.js Show resolved Hide resolved

Julesssss approved these changes Aug 1, 2022

View reviewed changes

Julesssss merged commit 4a9fa9b into main Aug 1, 2022

Julesssss deleted the beaman-refactorUserDelete branch August 1, 2022 13:57

OSBotify mentioned this pull request Aug 1, 2022

Deploy Checklist: New Expensify 2022-08-01 #10169

Closed

95 tasks

MonilBhavsar mentioned this pull request Aug 3, 2022

Security - Close Account - No growl is received when closing an account #10224

Closed

marcaaron reviewed Oct 5, 2022

View reviewed changes

Beamanator mentioned this pull request Oct 6, 2022

Remove incorrect Onyx prop initWithStoredValues #11628

Merged

93 tasks

aldo-expensify mentioned this pull request Dec 9, 2022

Dev - Infinite spinner while closing account [reported by Varsha] #13400

Closed

srikarparsi mentioned this pull request Dec 22, 2022

[No QA] refactor close account onyx refactor frontend 2 #13788

Merged

52 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Refactor] Use `CloseAccount` to replace `User_Delete` and refactor related pages #9635

[Refactor] Use `CloseAccount` to replace `User_Delete` and refactor related pages #9635

Beamanator commented Jun 30, 2022 •

edited

Loading

melvin-bot bot commented Jun 30, 2022

Beamanator commented Jun 30, 2022

marcaaron left a comment

Beamanator commented Jul 4, 2022

Beamanator commented Jul 8, 2022

Beamanator commented Jul 18, 2022

marcaaron commented Jul 19, 2022

Julesssss Jul 19, 2022

Beamanator Jul 19, 2022

Beamanator Jul 19, 2022

Julesssss left a comment

Beamanator commented Jul 19, 2022

Beamanator commented Jul 29, 2022

Beamanator commented Jul 29, 2022

Julesssss commented Aug 1, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 4, 2022

marcaaron Oct 5, 2022

Beamanator Oct 6, 2022

[Refactor] Use CloseAccount to replace User_Delete and refactor related pages #9635

[Refactor] Use CloseAccount to replace User_Delete and refactor related pages #9635

Conversation

Beamanator commented Jun 30, 2022 • edited Loading

Details

Fixed Issues

Tests (both Dev & Staging)

PR Review Checklist

Contributor (PR Author) Checklist

Screenshots

Web & Desktop

Mobile Web

iOS

Android

melvin-bot bot commented Jun 30, 2022

Beamanator commented Jun 30, 2022

marcaaron left a comment

Choose a reason for hiding this comment

Beamanator commented Jul 4, 2022

Beamanator commented Jul 8, 2022

Beamanator commented Jul 18, 2022

marcaaron commented Jul 19, 2022

Julesssss Jul 19, 2022

Choose a reason for hiding this comment

Beamanator Jul 19, 2022

Choose a reason for hiding this comment

Beamanator Jul 19, 2022

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

Beamanator commented Jul 19, 2022

Beamanator commented Jul 29, 2022

Beamanator commented Jul 29, 2022

Julesssss commented Aug 1, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 4, 2022

marcaaron Oct 5, 2022

Choose a reason for hiding this comment

Beamanator Oct 6, 2022

Choose a reason for hiding this comment

[Refactor] Use `CloseAccount` to replace `User_Delete` and refactor related pages #9635

[Refactor] Use `CloseAccount` to replace `User_Delete` and refactor related pages #9635

Beamanator commented Jun 30, 2022 •

edited

Loading