Dev - Infinite spinner while closing account [reported by Varsha]

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to new
2. go to Settings - Security - Close account
3. observe the Spinner on Close account button

Expected Result:

Infinite spinner should not be displayed

Actual Result:

Infinite spinner while closing account

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.36-2
Reproducible in staging?: Needs reproduction (Seems happening only in DEV)
Reproducible in production?: Needs reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/206235125-3f48bc96-1a81-4d1e-a0b9-2fcbd452e1c8.mov
Expensify/Expensify Issue URL:
Issue reported by: @varshamb
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670346549403099

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aldo-expensify]

I'm not being able to reproduce this in staging/web or any platform/dev. I'm going to ask a bit more in the slack thread.

[aldo-expensify]

We rely on the Pusher events clearing the Onyx data after a successful CloseAccount request, I'm guessing that the reporting user may be somehow missing these updates sent through pusher:

App/src/libs/actions/User.js

Lines 72 to 89 in 46f8297

	// Note: successData does not need to set isLoading to false because if the CloseAccount
	// command succeeds, a Pusher response will clear all Onyx data.
	API.write('CloseAccount', {message}, {
	optimisticData: [
	{
	onyxMethod: CONST.ONYX.METHOD.MERGE,
	key: ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM,
	value: {isLoading: true},
	},
	],
	failureData: [
	{
	onyxMethod: CONST.ONYX.METHOD.MERGE,
	key: ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM,
	value: {isLoading: false},
	},
	],
	});

[aldo-expensify]

@Beamanator since you worked on the refactor of CloseAccount, do you see why this could be happening?

I'm inclined to just closing the issue because I think this is rare case where the user is missing the pusher events (that's my theory at least). An easy fix could be to clear the Onyx data also on successData, but that would mean that we are not trusting the Pusher which our application heavily relies on.

[aldo-expensify]

This has been resolved, Cloudflare was blocking the request api/command=AuthenticatePusher which ended up causing the Pusher not to work.

@sonialiap Can you handle the reporting compensation for @varshamb 🙏

[aldo-expensify]

Internal PR that fixed the issue: https://github.com/Expensify/Terraform/pull/616

[sonialiap]

@varshamb could you please apply for this job https://www.upwork.com/jobs/~01e2831fb3d87a6543

[melvin-bot]

@sonialiap, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sonialiap]

Upwork proposal sent

[melvin-bot]

@sonialiap, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

waiting for @varshamb to approve offer so that I can issue payment

[sonialiap]

Payment issued and contract ended, closing