Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @marcaaron @Julesssss @Justicea83 since y'all are reviewing the related Web-E PR 👍
Details
As noted by @marcaaron here, we use
Onyx.clear()
when signing out of NewDot. This is fine but in the recent API refactor we need to callOnyx.clear
in a few places after closing an account (the related PRs & issue) & maybe even after signing inCurrently we do
Onyx.clear().then
becauseOnyx.set
is faster thanOnyx.clear
. We won't have to use.then
if we useOnyx.merge
though b/cOnyx.merge
is slower thanOnyx.clear
react-native-onyx/lib/Onyx.js
Lines 721 to 735 in 445769a
Related Issues
https://github.com/Expensify/Expensify/issues/213701
Automated Tests
Not needed, just adding the ability to have
clear
be anonyxMethod
Note: This PR was tested in combination with:
CloseAccount
to replaceUser_Delete
and refactor related pages App#9635Results here: https://github.com/Expensify/Web-Expensify/pull/34159#issuecomment-1179061881
Linked PRs
https://github.com/Expensify/App/pull/9635/files