Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Use
CloseAccount
to replaceUser_Delete
and refactor related pages #9635[Refactor] Use
CloseAccount
to replaceUser_Delete
and refactor related pages #9635Changes from all commits
c50bcb4
9dfaa32
4345f96
77c6728
4970ab6
3eca6e3
7a2a794
bb9e58b
2c2c07e
5466d2a
587b68c
8f9d9f6
fed23a9
46cc5b1
3d39f40
8a32a15
85ec2b3
64de3cf
53dc8b5
f7360b5
3ab21d1
318f5f1
510c2ef
35d73f1
149ec7a
2859a34
a393005
300f7ce
2e8f6a9
200e5a8
5c6cb1c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually expecting a boolean and not the values
https://github.com/Expensify/react-native-onyx/blob/main/API.md#connectmapping--number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohhhhh interesting, good catch. It looks like in that repo we default
initWithStoredValues
totrue
so I think I can pretty much just delete this line - we do actually want to load the page with the error / loading state stored