-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for patches #11
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8227b17
updates for patches
613f520
updates for patches
378fcab
wip
fb04e4e
wip
5d143eb
wip
932d8af
wip
2c2a351
wip
bdffa94
wip
17ba52f
wip
9c1d30f
wip
aafd328
wip
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,9 +141,30 @@ zopen_build() { | |
# use the specified commit hash | ||
echo "git reset fce38915e4c7c73c0e7f77bb13e2a78514968d35 --hard" | ||
git reset fce38915e4c7c73c0e7f77bb13e2a78514968d35 --hard | ||
# Modify DEPS via sed | ||
echo "Modify DEPS via sed" | ||
sed -i -f../../patches/DEPS.sed DEPS | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, you can use $ZOPEN_ROOT instead of relative directories |
||
# Use depot tools gclient sync | ||
echo "gclient sync -D" | ||
gclient sync -D | ||
# | ||
# echo apply patches | ||
# | ||
echo "Apply patch for overall repo" | ||
git apply ../../patches/git.20231122.fce38915e4.diff | ||
echo "Apply patch for toolchain config" | ||
cd build | ||
git apply ../../../patches/build/git.20231122.968682938b.diff | ||
echo "Apply patch for abseil c++ libaries" | ||
cd ../third_party/abseil-cpp | ||
git apply ../../../../patches/third_party/abseil-cpp/git.20231122.1e8861f03f.diff | ||
echo "Apply patch for googletest" | ||
cd ../googletest/src | ||
git apply ../../../../../patches/third_party/googletest/src/git.20231122.af29db7ec2.diff | ||
|
||
|
||
# return to v8port/v8base/v8 level | ||
cd ../../../.. | ||
|
||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
#!/bin/sh | ||
|
||
# The path and environment variables are updated as a result of the package install. | ||
# However, if the user installs the package and does not run the zopen-config | ||
# command in the current shell, then the path will not be there yet. In | ||
# this case check for the path in the current path. | ||
|
||
desired_path="zopen/usr/local/zopen/depot_tools/depot_tools-main" | ||
|
||
if expr "${PATH}" : ".*${desired_path}.*" 1>/dev/null ; then | ||
echo "Good. depot_tools is in path." | ||
else | ||
echo "Path to depot_tools missing. Adding it to path.." | ||
export PATH=${PATH}:${HOME}/${desired_path} | ||
fi | ||
|
||
|
||
# activate the virtual env | ||
echo "activating the virtual env - venv" | ||
. ${HOME}/zopen/usr/local/zopen/v8/v8-DEV/venv/bin/activate | ||
|
||
# update the virtual env | ||
python -m pip install -U pip | ||
|
||
|
||
# install the necessary requirements | ||
echo "Installing packages via requirements.txt..." | ||
pip install -r ${HOME}/zopen/usr/local/zopen/v8/v8-DEV/requirements.txt | ||
|
||
# Using depot_tools disable metrics. | ||
# Comment out this line if you wish to participate. | ||
gclient metrics --opt-out | ||
|
||
|
||
# provide a mechanism to resume work on v8 versus | ||
# ensure pristine. Assume by default the user | ||
# desires a pristine state and a fresh fetch. | ||
RESUME=0 | ||
while [ $# -gt 0 ]; do | ||
case "$1" in | ||
-resume) | ||
echo "-resume switch used. Skipping .gclient* delete" | ||
RESUME=1 | ||
shift | ||
;; | ||
-optionx) | ||
echo "option x used with value $2" | ||
echo "TODO: nothing to do yet" | ||
shift 2 | ||
;; | ||
*) | ||
echo "unknown option" | ||
echo "USAGE: $0 [-resume]" | ||
exit 1 | ||
;; | ||
esac | ||
done | ||
|
||
# remove any previous attempts of fetch | ||
# so as to pull a fresh copy. If this is the first time building | ||
# depot tools, these file will not be present and thus | ||
# no need to attempt to remove them. | ||
# NOTE: assuming v8 will be built in $HOME/zopen/dev/v8port/v8base | ||
if [ ${RESUME} -eq 0 ]; then | ||
echo "Attempting to delete any leftover .gclient* entries" | ||
if [ -d "${HOME}/zopen/dev/v8port/v8base" ]; then | ||
if [ -f "${HOME}/zopen/dev/v8port/v8base/.gclient_entries" ]; then | ||
rm ${HOME}/zopen/dev/v8port/v8base/.gclient_entries | ||
fi | ||
if [ -f "${HOME}/zopen/dev/v8port/v8base/.gclient" ]; then | ||
rm ${HOME}/zopen/dev/v8port/v8base/.gclient | ||
fi | ||
fi | ||
fi |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean you have the v8port patches directly under
$HOME/zopen/dev/patches/
? Because this line indicates there is a$HOME/zopen/dev/v8port/
that should contain thepatches
directory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the dir structure is like this: