updates for patches #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 29, 2024 14:06
netskink
requested review from
gabylb,
IgorTodorovskiIBM and
MikeFultonDev
as code owners
gabylb
reviewed
Feb 29, 2024
README.md
Outdated
| @@ -193,14 +193,14 @@ v8port/patches/. Adjust the path to v8port to match your environment. Example: | |||
| This is a large patch which updates multiple portions of the codebase. | |||
| ``` | |||
| $ cd $HOME/zopen/dev/v8base/v8 | |||
| $ git apply ../../v8port/patches/git.20231122.fce38915e4.diff | |||
| $ git apply ../../patches/git.20231122.fce38915e4.diff | |||
There was a problem hiding this comment.
Does this mean you have the v8port patches directly under $HOME/zopen/dev/patches/? Because this line indicates there is a $HOME/zopen/dev/v8port/ that should contain the patches directory.
There was a problem hiding this comment.
Yes, the dir structure is like this:
v8port
\_ v8base
\_ v8
|
Some errors with the current patch level during gclient stepThis is probably just a temporary google thing. This repeats a few times for various files. clone and buld of zoslibA high priority task is to change this over to the z/OS Open Tools version of this code. However in an effort to migrate from manual to framework build, this is simply redoing the manual effort. Perhaps the |
I didn't have a problem running the following just now. Can you try running the same sequence: |
buildenv
Outdated
| @@ -141,9 +141,50 @@ zopen_build() { | |||
| # use the specified commit hash | |||
| echo "git reset fce38915e4c7c73c0e7f77bb13e2a78514968d35 --hard" | |||
| git reset fce38915e4c7c73c0e7f77bb13e2a78514968d35 --hard | |||
| # Modify DEPS via sed | |||
| echo "Modify DEPS via sed" | |||
| sed -i -f../../patches/DEPS.sed DEPS | |||
There was a problem hiding this comment.
FYI, you can use $ZOPEN_ROOT instead of relative directories
Hello Gaby, this is different from what we did before. With that said, I've modifed the build env to match your current setup. See below: Never the less, this doesn't address the failure with zoslib.... |
|
Re the zoslib build failures: there's compiler options |
|
In the referenced config.py file: it seems you have environment variable |
Hello Gaby, thanks for your reply. I don't have an AWS credential file. |
|
I suggest reviewing all instances in depot_tools where |
|
The build log for relevant errors: |
|
@netskink re the latest clang error from zoslib build, try compiling this t.cc file: by running: |
Regarding the build, of zoslib. it works manually. After that, I change to the zoslib dir in third_party and it builds fine. |
|
Now that there's no more a need to run commands on a non z/OS platform, please update README.md to remove the affected sections (Linux platform (non z/OS® UNIX System Services (z/OS UNIX)) setup, rm -rf test tools third_party, etc.). |
Hello Gaby, yes, indeed. I forgot to update that. Many thanks for reminding me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add: