feat: implement client compact #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
==========================================
- Coverage 53.38% 53.35% -0.04%
==========================================
Files 96 96
Lines 14853 14886 +33
Branches 14853 14886 +33
==========================================
+ Hits 7930 7942 +12
- Misses 6427 6451 +24
+ Partials 496 493 -3
☔ View full report in Codecov by Sentry. |
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
|
Is this pr based on #399 ？ |
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Phoenix500526
approved these changes
Aug 2, 2023
iGxnon
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on: #311
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
The compact method in
xline-clientcan be implement after feat/compactor #311what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)