Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/compactor #311

Merged
merged 9 commits into from
Jul 25, 2023
Merged

feat/compactor #311

merged 9 commits into from
Jul 25, 2023

Conversation

Phoenix500526
Copy link
Collaborator

Read #188 for more details.

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@Phoenix500526 Phoenix500526 force-pushed the feature/compactor branch 3 times, most recently from 43cc402 to 20c0240 Compare June 27, 2023 04:55
@xline-kv xline-kv deleted a comment from codecov bot Jun 27, 2023
@xline-kv xline-kv deleted a comment from codecov bot Jun 28, 2023
@xline-kv xline-kv deleted a comment from codecov bot Jun 28, 2023
@Phoenix500526 Phoenix500526 force-pushed the feature/compactor branch 6 times, most recently from 49bbbf5 to e84662f Compare July 2, 2023 11:49
@xline-kv xline-kv deleted a comment from codecov bot Jul 3, 2023
@xline-kv xline-kv deleted a comment from codecov bot Jul 4, 2023
@Phoenix500526 Phoenix500526 marked this pull request as ready for review July 4, 2023 01:28
@Phoenix500526 Phoenix500526 force-pushed the feature/compactor branch 3 times, most recently from 7c3c174 to a83a9ae Compare July 5, 2023 07:24
xline/src/server/command.rs Outdated Show resolved Hide resolved
xline/src/server/command.rs Outdated Show resolved Hide resolved
xline/src/server/command.rs Outdated Show resolved Hide resolved
xline/src/server/command.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 81.02% and project coverage change: +2.06% 🎉

Comparison is base (084b84d) 51.36% compared to head (3f8cedb) 53.42%.

❗ Current head 3f8cedb differs from pull request most recent head 44d8fc4. Consider uploading reports for the commit 44d8fc4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   51.36%   53.42%   +2.06%     
==========================================
  Files          95       96       +1     
  Lines       14069    14847     +778     
  Branches    14069    14847     +778     
==========================================
+ Hits         7226     7932     +706     
- Misses       6376     6420      +44     
- Partials      467      495      +28     
Files Changed Coverage Δ
xline-test-utils/src/lib.rs 1.02% <0.00%> (-0.02%) ⬇️
xline/src/server/xline_server.rs 0.00% <0.00%> (ø)
xline/src/storage/revision.rs 97.05% <ø> (ø)
xline/src/storage/kv_store.rs 71.01% <64.35%> (+6.30%) ⬆️
xline/src/storage/compact/mod.rs 70.83% <70.83%> (ø)
utils/src/config.rs 83.92% <74.28%> (-0.87%) ⬇️
xlineapi/src/lib.rs 59.47% <83.33%> (+2.32%) ⬆️
xline/src/server/kv_server.rs 51.34% <84.44%> (+14.30%) ⬆️
xline/src/server/watch_server.rs 79.53% <84.94%> (+0.39%) ⬆️
xline/src/server/command.rs 73.30% <96.58%> (+6.56%) ⬆️
... and 3 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

themanforfree
themanforfree previously approved these changes Jul 18, 2023
1. implement index compact logic and add test to cover
2. implement KvStore compact logic and add test to cover

Refs: xline-kv#188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: xline-kv#188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: xline-kv#188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: xline-kv#188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: xline-kv#188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: 188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: xline-kv#188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: 188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
@Phoenix500526 Phoenix500526 force-pushed the feature/compactor branch 2 times, most recently from 49e0fac to 28cadab Compare July 24, 2023 11:32
@Phoenix500526 Phoenix500526 requested a review from bsbds July 25, 2023 00:01
xline/src/server/kv_server.rs Outdated Show resolved Hide resolved
xline/src/server/xline_server.rs Outdated Show resolved Hide resolved
* unify the argument between PutKeyValue and DeleteKeyValue
* move compact.rs into compact mod
* using a bounded channel to replace the unbounded channel (compact_task_tx, compact_task_rx)

Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
@mergify mergify bot merged commit a48b303 into xline-kv:master Jul 25, 2023
17 checks passed
@Phoenix500526 Phoenix500526 deleted the feature/compactor branch September 23, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants