-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: execution error types #399
Conversation
5744b56
to
7506756
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 52.34% 52.44% +0.10%
==========================================
Files 97 98 +1
Lines 15166 15102 -64
Branches 15166 15102 -64
==========================================
- Hits 7938 7920 -18
+ Misses 6733 6686 -47
- Partials 495 496 +1
☔ View full report in Codecov by Sentry. |
7506756
to
04bfd28
Compare
04bfd28
to
e40a66b
Compare
I think this implementation is too invasive for the curp consensus. |
94eeac6
to
51b7123
Compare
I have pushed another refactored version @Phoenix500526 @rogercloud @iGxnon |
598c9b5
to
35925cd
Compare
879d3ec
to
5295505
Compare
The ProposeError originally include `RpcError`, however, in the current curp code, it does not return the rpc error to user but handle the rpc error internally, there's no need to keep it in ProposeError. Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
…and` Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
5295505
to
54d7f8c
Compare
Described in: #397
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)