Fix elevation not visible on bottomTabs #7519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogevbd
previously approved these changes
May 2, 2022
guyca
added a commit
that referenced
this pull request
May 23, 2022
#7519 fixed missing elevation of bottomTabs by applying the background color on the bottomTabs container. While it fixed the elevation bug, it introduced a bug where the default background color of the bottomTabs overlapped the background color applied on the container. This commit sets the default background color to transparent to fix the issue.
yogevbd
pushed a commit
that referenced
this pull request
May 23, 2022
#7519 fixed missing elevation of bottomTabs by applying the background color on the bottomTabs container. While it fixed the elevation bug, it introduced a bug where the default background color of the bottomTabs overlapped the background color applied on the container. This commit sets the default background color to transparent to fix the issue.
|
It looks not working well on Dark mode. |
|
@thuongtv-vn Can you please check if it looks as expected in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently elevation doesn't work if the view it's applied on doesn't have a background color. Regression introduced in #6958
Fixes #7422