Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom tabs shadow default visibility #6958

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Bottom tabs shadow default visibility #6958

merged 3 commits into from
Feb 11, 2021

Conversation

swabbass
Copy link
Contributor

shadow was enabled by default, changed to opt-in, by having valid shadow options in the BottomTabsOptions

@swabbass swabbass self-assigned this Feb 11, 2021
@yogevbd yogevbd merged commit a867b41 into master Feb 11, 2021
@yogevbd yogevbd deleted the bottom_tabs_shadow_default_visibility branch February 11, 2021 13:28
guyca added a commit that referenced this pull request May 2, 2022
@guyca
Fix elevation not visible on bottomTabs
1b873ed 
Apparently elevation doesn't work if the view it's applied on doesn't have a background color. Regression introduced in #6958

Fixes #7422
@guyca guyca mentioned this pull request May 2, 2022
Merged
guyca added a commit that referenced this pull request May 2, 2022
@guyca
Fix elevation not visible on bottomTabs
a4c9534 
Apparently elevation doesn't work if the view it's applied on doesn't have a background color. Regression introduced in #6958

Fixes #7422
guyca added a commit that referenced this pull request May 3, 2022
@guyca @yogevbd
Fix elevation not visible on bottomTabs (#7519)
56ccaea 
Apparently elevation doesn't work if the view it's applied on doesn't have a background color. Regression introduced in #6958

Fixes #7422

Co-authored-by: Yogev Ben David <yogev132@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogevbd yogevbd yogevbd approved these changes

Assignees

@swabbass swabbass

Labels
platform: Android type: accepted/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swabbass @yogevbd