Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue BottomTabs Elevation not working on Android #7517

Closed
wants to merge 2 commits into from
Closed

Fix issue BottomTabs Elevation not working on Android #7517

wants to merge 2 commits into from

Conversation

vnhanh
Copy link

@vnhanh vnhanh commented Apr 30, 2022

This issue was raised on this link: #7422

The code which sets bottomtabs elevation:
Navigation.setDefaultOptions({
statusBar: {
backgroundColor: '#4d089a'
},
topBar: {
title: {
color: 'white'
},
backButton: {
color: 'white'
},
background: {
color: '#4d089a'
}
},
bottomTab: {
fontSize: 14,
selectedFontSize: 14,
selectedTextColor: '#069A8E',
selectedIconColor: '#069A8E'
},
bottomTabs: {
titleDisplayMode: 'alwaysShow',
iconWidth: 24,
iconHeight: 24,
elevation: 8,
}
});

With the version "7.27.1", the android application doesn't show elevation like this picture:
rnn_no_elevation

And if using the fixing code from my branch, it will show elevation:
rnn_elevation

Please check carefully, you can see the elevation in the second picture.

@Andarius
Copy link
Contributor

Andarius commented May 2, 2022

Hey @vnhanh, from what I understood from this issue #7476 is that the elevation is displayed under the bottomTabs and not above. Does this fix the same issue or is it another fix ?

@guyca
Copy link
Collaborator

guyca commented May 2, 2022

Thanks a lot @vnhanh! Your effort helped me find a slightly better solution in #7519

@guyca guyca closed this May 2, 2022
@vnhanh
Copy link
Author

vnhanh commented May 3, 2022

@guyca OK, I'm glad to help everyone develop this library. Thanks for reviewing.
@Andarius My pull request fixes to show shadow on the above of the BottomTabs's top edge. I read the issue in #7746 and I think my code can fix that issue, but @guyca found a better solution, so I think you can wait more until your issue is fixed. Thanks for reading my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants