-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor VDT integration tests: feeds and scan types #2650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…runcate_log_files #2520
Due to the new feed structure changes
…ility-removal Vulnerability detector test module refactor: `test_alert_vulnerability_removal`
…a into 2528-refactor-scan-nvd
Vulnerability detector test module refactor: test_scan_nvd_feed
…te-vulns Vulnerability detector test module refactor: `test_duplicate_feeds`
Vulnerability detector test module refactor: `test_validate_feed_content`
Necessary due to compatibilities issues, since datetime.fromisoformat needs python >=3.7.0
Add new logic to check if a downloaded feed has been recently updated in `test_downloads_feeds` module
…ctor-improvements
Rebits
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the test refactor to the test feeds, and the scan types. It also adds new feed organization, and standardizes all VDT test files.
The changes made are as follows
Changes in tests
Refactored test modules
test_feeds/test_cpe_indexing.py
test_feeds/test_download_feeds.py
test_feeds/test_duplicate_feeds.py
test_feeds/test_import_invalid_feed_type.py
test_general_settings/test_interval.py
test_scan_results/test_scan_nvd.py
test_scan_types/test_baseline_scan_type.py
test_scan_types/test_full_scan_type.py
test_scan_types/test_partial_scan_type.py
Test modules added
test_vulnerability_inventory/test_vulnerability_inventory_baseline_scan.py
test_vulnerability_inventory/test_vulnerability_inventory_full_scan.py
test_vulnerability_inventory/test_vulnerability_inventory_partial_scan.py
Tests eliminated
test_feeds/test_extra_tags_*_feed.py
test_feeds/test_invalid_syntax_*_feed.py
test_feeds/test_invalid_values_*_feed.py
test_feeds/test_missing_tags_*_feed.py
Changes in the framework
Added
wazuh_testing
module.agent_db
module.global_db
module.mocking
module.mocking
module.time
module to parse datetimes from feeds.Improved
Deleted
utils
module from vulnerability detector.Tests
Checks
The following checks have been proven with the following package
Round 1 🟢
Round 2 🟢
Round 3 🟢
Round 4 🟢
Round 5 🟢
Analysisd IT - Tier 0 - manager
Analysisd IT - Tier 1 - manager
AR IT - Tier 0 - manager
AR IT - Tier 1 - centos_agent
Authd IT - Tier 0 - manager
Authd IT - Tier 1 - manager
FIM IT - Tier 0 - centos_agent
FIM IT - Tier 0 - manager
FIM IT - Tier 1 - centos_agent
FIM IT - Tier 1 - manager
Logtest IT - Tier 0 - manager
Remoted IT - Tier 0 - manager
Remoted IT - Tier 1 - manager
Rids IT - Tier 0 - manager
Rootcheck IT - Tier 0 - manager
Rootcheck IT - Tier 1 - manager
Vul. Det. IT - Tier 0 - manager
Vul. Det. IT - Tier 1 - manager
Wazuh DB IT - Tier 0 - manager