Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability detector test module refactor: test_scan_nvd_feed #2528

Closed
10 of 11 tasks
Tracked by #2519
jmv74211 opened this issue Feb 1, 2022 · 0 comments
Closed
10 of 11 tasks
Tracked by #2519

Vulnerability detector test module refactor: test_scan_nvd_feed #2528

jmv74211 opened this issue Feb 1, 2022 · 0 comments
Assignees
Labels
feature/vuln-detector refactor Redesign and implement an existing development/feature test/integration

Comments

@jmv74211
Copy link
Contributor

jmv74211 commented Feb 1, 2022

It is asked to refactor the test module named test_scan_nvd_feed.py.

It is disabled for now, as it was failing or unstable, causing false positives.

Tasks

  • Make a study of the objectives of the test, and what is being tested.
  • Refactor the test. Clean and modularizable code.
  • Check that the test always starts from the same state and restores it completely at the end of the test (independent of the tests previously executed in that environment).
  • Review test documentation, and modify if necessary.
  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Test in 5-10 rounds of execution that the test always shows the same result.
  • Run all Vulnerability detector integration tests and check the "full green".

Checks

  • The code complies with the standard PEP-8 format.
  • Python codebase is documented following the Google Style for Python docstrings.
  • The test is processed by qa-docs tool without errors.
@jmv74211 jmv74211 added team/qa refactor Redesign and implement an existing development/feature test/integration feature/vuln-detector labels Feb 1, 2022
@jmv74211 jmv74211 self-assigned this Feb 7, 2022
jmv74211 added a commit that referenced this issue Feb 14, 2022
jmv74211 added a commit that referenced this issue Feb 14, 2022
Due to the new feed structure changes
jmv74211 added a commit that referenced this issue Feb 15, 2022
jmv74211 added a commit that referenced this issue Feb 15, 2022
jmv74211 added a commit that referenced this issue Feb 15, 2022
jmv74211 added a commit that referenced this issue Feb 15, 2022
jmv74211 added a commit that referenced this issue Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vuln-detector refactor Redesign and implement an existing development/feature test/integration
Projects
None yet
Development

No branches or pull requests

1 participant