Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability detector test module refactor: test_alert_vulnerability_removal #2565

Conversation

fedepacher
Copy link
Contributor

@fedepacher fedepacher commented Feb 9, 2022

Related issue
#2520

Description

This PR adds changes and enhancements to the testing framework for vulnerability detector.

The changes made are as follows:

Added

  • Add new functions to check log events.
  • Add testing module: test_alert_vulnerability_removal and data.

Improvements

  • Added a new structure to the test.
  • Refactor the test in order to get PASSED.

Tests

  • All vulnerability detector tests
  • test_alert_vulnerability_removal

Outputs

All vulnerability detector tests
================================== test session starts ===================================
platform linux -- Python 3.6.8, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: /mnt/qa/tests/integration, configfile: pytest.ini
plugins: metadata-1.11.0, testinfra-5.0.0, html-3.1.1
collected 2577 items                                                                     

test_vulnerability_detector/test_feeds/test_download_feeds.py ssssssssssssssss     [  0%]
test_vulnerability_detector/test_feeds/test_invalid_type_custom_feeds.py sssssssss [  0%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [  4%]
sssssssssssssssssssssssssss                                                        [  5%]
test_vulnerability_detector/test_feeds/test_invalid_type_url_feeds.py ssssssssssss [  5%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [  8%]
ssssssssssssssssssssssss                                                           [  9%]
test_vulnerability_detector/test_feeds/test_validate_feed_content.py ............. [ 10%]
.........................                                                          [ 11%]
test_vulnerability_detector/test_feeds/alas/test_extra_tags_alas_feed.py sssssssss [ 11%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 14%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 17%]
sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss            [ 20%]
test_vulnerability_detector/test_feeds/alas/test_invalid_syntax_alas_feed.py sssss [ 20%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 24%]
sssssssssssssssssssssss                                                            [ 24%]
test_vulnerability_detector/test_feeds/alas/test_invalid_values_alas_feed.py sssss [ 25%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 28%]
sssssssssssssssssssssssssssssssssss                                                [ 29%]
test_vulnerability_detector/test_feeds/alas/test_missing_tags_alas_feed.py sssssss [ 29%]
sssssss                                                                            [ 30%]
test_vulnerability_detector/test_feeds/archlinux/test_extra_tags_archlinux_feed.py s [ 30%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 33%]
sssssssssssssssssssssssssssssssssssssss                                            [ 35%]
test_vulnerability_detector/test_feeds/archlinux/test_invalid_syntax_archlinux_feed.py s [ 35%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssss                             [ 37%]
test_vulnerability_detector/test_feeds/archlinux/test_invalid_values_archlinux_feed.py s [ 37%]
ssssssssssssssssssss                                                               [ 37%]
test_vulnerability_detector/test_feeds/archlinux/test_missing_tags_archlinux_feed.py s [ 37%]
ssssssssss                                                                         [ 38%]
test_vulnerability_detector/test_feeds/canonical/test_extra_tags_canonical_feed.py s [ 38%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 41%]
sssssssssssssssssssssssssssssssssssssss                                            [ 43%]
test_vulnerability_detector/test_feeds/canonical/test_invalid_syntax_canonical_feed.py s [ 43%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 46%]
                                                                                   [ 46%]
test_vulnerability_detector/test_feeds/canonical/test_invalid_values_canonical_feed.py s [ 46%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 49%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 52%]
ssssss                                                                             [ 52%]
test_vulnerability_detector/test_feeds/canonical/test_missing_tags_canonical_feed.py s [ 53%]
ssssssssssssssssssssssssssssssss                                                   [ 54%]
test_vulnerability_detector/test_feeds/debian/test_extra_tags_debian_feed.py sssss [ 54%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 57%]
sssssssssssssssssssssssssssssssssss                                                [ 58%]
test_vulnerability_detector/test_feeds/debian/test_invalid_syntax_debian_feed.py s [ 59%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 62%]
                                                                                   [ 62%]
test_vulnerability_detector/test_feeds/debian/test_invalid_values_debian_feed.py s [ 62%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss   [ 65%]
test_vulnerability_detector/test_feeds/debian/test_missing_tags_debian_feed.py sss [ 65%]
sssssssssssssssssssssssssssssssssss                                                [ 66%]
test_vulnerability_detector/test_feeds/msu/test_extra_fields_msu_feed.py sssssssss [ 67%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 70%]
sssssssssssssssssssssssssssssss                                                    [ 71%]
test_vulnerability_detector/test_feeds/msu/test_invalid_syntax_msu_feed.py sssssss [ 71%]
ssssssssssssssssssssssssssssssssssssssssssssssssss                                 [ 73%]
test_vulnerability_detector/test_feeds/msu/test_invalid_values_msu_feed.py sssssss [ 74%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssss                             [ 76%]
test_vulnerability_detector/test_feeds/msu/test_missing_fields_msu_feed.py sssssss [ 76%]
                                                                                   [ 76%]
test_vulnerability_detector/test_feeds/redhat/test_extra_fields_redhat_feed.py sss [ 76%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 79%]
sssssssssssssssssssssssssssssssssssss                                              [ 81%]
test_vulnerability_detector/test_feeds/redhat/test_invalid_syntax_redhat_feed.py s [ 81%]
sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss  [ 84%]
test_vulnerability_detector/test_feeds/redhat/test_invalid_values_redhat_feed.py s [ 84%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 87%]
sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss      [ 90%]
test_vulnerability_detector/test_feeds/redhat/test_missing_fields_redhat_feed.py s [ 90%]
ssssssssssssssssssssssssss                                                         [ 91%]
test_vulnerability_detector/test_general_settings/test_enabled.py ..               [ 91%]
test_vulnerability_detector/test_general_settings/test_interval.py ............    [ 92%]
test_vulnerability_detector/test_general_settings/test_min_full_scan_interval.py . [ 92%]
                                                                                   [ 92%]
test_vulnerability_detector/test_general_settings/test_retry_interval.py ..        [ 92%]
test_vulnerability_detector/test_general_settings/test_run_on_start.py ..          [ 92%]
test_vulnerability_detector/test_providers/test_enabled.py ....................... [ 93%]
.........................................                                          [ 94%]
test_vulnerability_detector/test_providers/test_missing_os.py ..............       [ 95%]
test_vulnerability_detector/test_providers/test_multiple_provider_feeds.py ....    [ 95%]
test_vulnerability_detector/test_providers/test_os.py ............................ [ 96%]
....                                                                               [ 96%]
test_vulnerability_detector/test_providers/test_update_from_year.py ..........     [ 97%]
test_vulnerability_detector/test_providers/test_update_interval.py ......          [ 97%]
test_vulnerability_detector/test_scan_results/test_alas_inventory_alas_feed.py ss  [ 97%]
test_vulnerability_detector/test_scan_results/test_alert_vulnerability_removal.py . [ 97%]
.                                                                                  [ 97%]
test_vulnerability_detector/test_scan_results/test_archlinux_inventory_archlinux_feed.py s [ 97%]
s                                                                                  [ 97%]
test_vulnerability_detector/test_scan_results/test_debian_inventory_debian_feed.py s [ 97%]
s                                                                                  [ 97%]
test_vulnerability_detector/test_scan_results/test_macos_inventory.py ss           [ 97%]
test_vulnerability_detector/test_scan_results/test_msu_inventory_msu_feed.py sss   [ 97%]
test_vulnerability_detector/test_scan_results/test_redhat_duplicate_vulns.py sss   [ 97%]
test_vulnerability_detector/test_scan_results/test_redhat_inventory_redhat_feed.py s [ 98%]
sss                                                                                [ 98%]
test_vulnerability_detector/test_scan_results/test_scan_different_cves.py ssssssss [ 98%]
ssss                                                                               [ 98%]
test_vulnerability_detector/test_scan_results/test_scan_nvd_feed.py ssssssssssssss [ 99%]
ss                                                                                 [ 99%]
test_vulnerability_detector/test_scan_results/test_scan_providers_and_nvd_feed.py s [ 99%]
sssssssssss                                                                        [ 99%]
test_vulnerability_detector/test_scan_results/test_ubuntu_inventory_canonical_feed.py s [ 99%]
sss                                                                                [ 99%]
test_vulnerability_detector/test_scan_types/test_baseline_scan_type.py s           [ 99%]
test_vulnerability_detector/test_scan_types/test_full_scan_type.py .               [ 99%]
test_vulnerability_detector/test_scan_types/test_partial_scan_type.py s            [ 99%]
test_vulnerability_detector/test_windows/test_cpe_indexing.py s                    [100%]

===================== 190 passed, 2387 skipped in 1730.04s (0:28:50) =====================

test_alert_vulnerability_removal
================================== test session starts ===================================
platform linux -- Python 3.6.8, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: /mnt/qa/tests/integration, configfile: pytest.ini
plugins: metadata-1.11.0, testinfra-5.0.0, html-3.1.1
collected 2 items                                                                        

test_vulnerability_detector/test_scan_results/test_alert_vulnerability_removal.py . [ 50%]
.                                                                                  [100%]

============================== 2 passed in 85.09s (0:01:25) ==============================

@jmv74211 jmv74211 changed the base branch from 2460-refactor-vuln-basic-configuration to 2519-refactor-scan-results February 14, 2022 07:50
@jmv74211 jmv74211 merged commit 1b41300 into 2519-refactor-scan-results Feb 14, 2022
@jmv74211 jmv74211 deleted the 2520-refactor-test-alert-vulnerability-removal branch February 14, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants