Allow for stepdown of minor versions #53
Conversation
|
Puppet Inc is currently working on getting updated facts for all supported platforms and facter versions into facterdb, and providing timely updates in the future. I would prefer the stepdown here not be merged, as it will become obsolete within the next few days. |
|
Except for the next release we will end up with the same week delay. |
Due to voxpupuli/rspec-puppet-facts#53 some of our unti tests are failing on Travis. This fix averts these errors for the meantime while still running the same test.
|
Can we get an answer on this. It is still blocking some of my users. |
- FacterDB has not been updated and might not be updated regularly to meet the need of new versions drop this will allow the system to find the previous minor version but not cross major versions
- Test will only be exercised if the FACTER_GEM_VERSION is ~> 2.0
This fixes a syntax error in a code example, and formatting of the last section.
lib/rspec-puppet-facts.rb
Outdated
| @@ -161,6 +178,13 @@ def self.spec_facts_os_filter | |||
| ENV['SPEC_FACTS_OS'] | |||
| end | |||
|
|
|||
| # If SPEC_FACTS_STRICT is set to `yes`, RspecPuppetFacts will error on missing FacterDB entries, instead of warning & skipping. | |||
| # @return [nil,String] | |||
There was a problem hiding this comment.
Returned data type should always be a boolean
lib/rspec-puppet-facts.rb
Outdated
| # @return [nil,String] | ||
| # @api private | ||
| def self.spec_facts_strict? | ||
| ENV['SPEC_FACTS_STRICT'] == 'yes' |
There was a problem hiding this comment.
Rather than needing specifically 'yes', could this be set to anything (or set to anything that isn't 'no')?
lib/rspec-puppet-facts.rb
Outdated
| @@ -161,6 +178,13 @@ def self.spec_facts_os_filter | |||
| ENV['SPEC_FACTS_OS'] | |||
| end | |||
|
|
|||
| # If SPEC_FACTS_STRICT is set to `yes`, RspecPuppetFacts will error on missing FacterDB entries, instead of warning & skipping. | |||
There was a problem hiding this comment.
This says 'skipping' but the behaviour is to attempt to use an older version of facts; so 'skipping' may be misleading
Folks with high confidence needs can use this to elide the permissive behaviour.
This is entirely rspec-puppet-facts code, and should not depend on facter, or FacterDB
No description provided.