Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create facter 2.5 files to support the release of facter 2.5 #44

Closed
wants to merge 1 commit into from
Closed

Create facter 2.5 files to support the release of facter 2.5 #44

wants to merge 1 commit into from

Conversation

cyberious
Copy link

  • Copied files from 2.4 and modified puppetversion to 4.10.2 and facterversion to 2.5.0

Create facter 2.5 files to support the release of facter 2.5
8876147 
- Copied files from 2.4 and modified puppetversion to 4.10.2 and facterversion to 2.5.0
@cyberious
Copy link
Author

errors look unrelated to my PR

@mcanevet
Copy link
Member

@cyberious I'd prefer not not copy/paste/modify facts, but generate it from scratch with real version of Puppet Agent using the scripts provided

@baurmatt
Copy link
Contributor

This is definitely needed as rspec tests seem to be broken for Facter 2.5.0 and Windows facts.

@baurmatt baurmatt mentioned this pull request Jul 19, 2017
Closed
@rtib rtib mentioned this pull request Jul 20, 2017
Closed
@cdenneen
Copy link

Until this can be done as desired can someone update the gemspec to <2.5.0 of facter?

@cyberious
Copy link
Author

voxpupuli/rspec-puppet-facts#53 have a fix for rspec-puppet-facts if relevant

@tuxmea tuxmea mentioned this pull request Jul 21, 2017
Merged
@vladgh
Copy link

vladgh commented Jul 23, 2017

Any update on this?

@rodjek
Copy link
Member

rodjek commented Jul 26, 2017

I've generated 2.5 fact sets for many of the operating systems in #46

@DavidS
Copy link
Contributor

DavidS commented Jul 27, 2017

Fixed in #46

@DavidS DavidS closed this Jul 27, 2017
tux-o-matic pushed a commit to DanskSupermarked/puppet-puppetboard that referenced this pull request Jul 27, 2017
Making CI use Facter 2.4.6 until FacterDB release fix of voxpupuli/fa…
7905729 
…cterdb#44
@b4ldr b4ldr mentioned this pull request Sep 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cyberious @mcanevet @baurmatt @cdenneen @vladgh @rodjek @DavidS