Solaris/upstream #950
Closed
Solaris/upstream #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnferry
force-pushed
the
solaris/upstream
branch
2 times, most recently
from
0f1352f
to
a5145f2
Compare
shawnferry
force-pushed
the
solaris/upstream
branch
2 times, most recently
from
d12db93
to
02ab309
Compare
shawnferry
force-pushed
the
solaris/upstream
branch
3 times, most recently
from
c845d86
to
6269c84
Compare
shawnferry
force-pushed
the
solaris/upstream
branch
2 times, most recently
from
89485b7
to
dee58a8
Compare
(MODULES-5277) puppetlabs-mysql : default version fact is not set on Solaris This patch adds Solaris support as currently shipped by Oracle. Mysql version is extracted from `pkg mediator mysql` and used to set path values. This patch also adds the structured fact mysql_solaris which holds values for consumption in params.pp
Solaris 12 is now Solaris 11.4 metadata.json needs an update
…be 5.7 Mysql 5.5 has been EOLd and will be removed from Solaris. The new default version should be 5.7. If mysql is installed or mediated that version will be used instead.
shawnferry
force-pushed
the
solaris/upstream
branch
from
dee58a8
to
5979677
Compare
|
@shawnferry Is there any movement on this PR? |
|
I'm looking at it now |
Fails on newer MySQL versions
db51029 added support for Stretch but didn't add this to the metadata.
This is triggering PUP-7925, causing the mysql module being unusable on all existing puppet versions.
[skip-ci]
Currently task setup is trying to run on LTS which causes failures as it is not supported.
If set `bind-address` to `undef` the bind-address will not be set in the mysql-config file so MySQL is listening on all interfaces.
```puppet
class { '::mysql::server':
override_options => {
mysqld => {
bind-address => undef,
},
}
```
...so they can all be modified from one place. The current codebase handles each mysql call via calls to the command-line mysql client. There are basically only two sets of options passed, but the options are repeated separately in various places throughout the code. The new self.mysql function now issues the call to the mysql client with one of the two sets of options (selected via an optional function parameter). Now the options to all mysql calls can be modified from one place. This will be useful when we are converting the module to allow for databases on multiple remote servers, since we will be able to add the -h switch to all calls at once.
mysql_grant now checks for mysql command
This also adds back the debian 9 metadata because it was removed after 5.1.0 was released.
For whatever reason, rubocop cannot see that stderr is indeed a used variable.
A puppet classname has 2 colons (:) in its name.
changed option in export.json from sql to file, probably a copy paste issue
(MODULES-5277) puppetlabs-mysql : default version fact is not set on Solaris This patch adds Solaris support as currently shipped by Oracle. Mysql version is extracted from `pkg mediator mysql` and used to set path values. This patch also adds the structured fact mysql_solaris which holds values for consumption in params.pp
|
Hey @shawnferry, Apologies but with this PR lying stale for so long I am going to close this. It needs a lot of work to get it rebased and up to date. If you disagree with my action please do not hesitate to reopen the PR and in advance apologize for my misjudgment. I would like to reiterate how grateful we are as a team for your contribution. Many Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(MODULES-4749) puppetlabs-mysql : Solaris support
(MODULES-5277) puppetlabs-mysql : default version fact is not set on Solaris
(MODULES-5495) puppetlabs-mysql : the OS formerly known as Solaris 12
This patch adds Solaris support as currently shipped by Oracle. Mysql
version is extracted from
pkg mediator mysqland used to set pathvalues.
This patch also adds the structured fact mysql_solaris which holds
values for consumption in params.pp
Solaris 12 is now Solaris 11.4
(MODULES-5494) puppetlabs-mysql : default version for Solaris should be 5.7
Mysql 5.5 has been EOLd and will be removed from Solaris. The new default version should be 5.7. If mysql is installed or mediated that version will be used instead.