Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update instructions for pnpm 7.1.1 #37240

Closed
wants to merge 1 commit into from

Conversation

Intellicode
Copy link

@Intellicode Intellicode commented May 27, 2022

Arguments are now passed to the next-app by default since pnpm 7.1.1

Documentation / Examples

  • Make sure the linting passes by running yarn lint
  • The examples guidelines are followed from our contributing doc

Arguments are now passed to the next-app by default since pnpm 7.1.1
@balazsorban44
Copy link
Member

Thanks! Please see #37049

As far as I am aware, newer versions of pnpm will work with -- as well, but not the other way around, so let's keep this for a while until the adoption of newer pnpm versions has increased.

@Intellicode
Copy link
Author

Intellicode commented May 27, 2022

Thanks! Please see #37049

As far as I am aware, newer versions of pnpm will work with -- as well, but not the other way around, so let's keep this for a while until the adoption of newer pnpm versions has increased.

The reason I stumbled upon is, is that with the instructions with -- it created a --typescript directory with pnpm 7.1.6, so at least with this version the instructions are not compatible.

➜  pnpm create next-app -- --typescript
...
Creating a new Next.js app in /Users/tom/repos/react-playground/pnpm-test/--typescript.
...
➜  pnpm-test ls -la
total 0
drwxr-xr-x  13 tom  staff  416 May 27 16:10 --typescript

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated everywhere.

I created #37254

@kodiakhq kodiakhq bot closed this in #37254 May 27, 2022
kodiakhq bot pushed a commit that referenced this pull request May 27, 2022
This command changed in pnpm [6.32.13](https://github.com/pnpm/pnpm/releases/tag/v6.32.13) and [7.1.1](https://github.com/pnpm/pnpm/releases/tag/v7.1.1) so lets update it since its been a few weeks and we can expect pnpm users to update more regularly than npm users.

- Fixes #37240 
- Fixes #37045
- Fixes #37032
- Fixes #36602
- Fixes #36496
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2022
LuighiV pushed a commit to openpolitica/create-openpolitica-nextjs-app that referenced this pull request Aug 24, 2022
This command changed in pnpm [6.32.13](https://github.com/pnpm/pnpm/releases/tag/v6.32.13) and [7.1.1](https://github.com/pnpm/pnpm/releases/tag/v7.1.1) so lets update it since its been a few weeks and we can expect pnpm users to update more regularly than npm users.

- Fixes vercel/next.js#37240 
- Fixes vercel/next.js#37045
- Fixes vercel/next.js#37032
- Fixes vercel/next.js#36602
- Fixes vercel/next.js#36496
slukin1 pushed a commit to slukin1/tempppp that referenced this pull request Jul 17, 2023
This command changed in pnpm [6.32.13](https://github.com/pnpm/pnpm/releases/tag/v6.32.13) and [7.1.1](https://github.com/pnpm/pnpm/releases/tag/v7.1.1) so lets update it since its been a few weeks and we can expect pnpm users to update more regularly than npm users.

- Fixes vercel/next.js#37240 
- Fixes vercel/next.js#37045
- Fixes vercel/next.js#37032
- Fixes vercel/next.js#36602
- Fixes vercel/next.js#36496
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants