fixes pnpm create command (removes extra '--' ) #36496

rkzofficial · 2022-04-27T06:33:51Z

Before:
pnpm create next-app -- --typescript

After:
pnpm create next-app --typescript

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

Before: pnpm create next-app -- --typescript After: pnpm create next-app --typescript

balazsorban44 · 2022-04-27T12:27:28Z

I think this is related to #36360, but ironically your suggestion throws an error for me locally.

Do you have some documentation link why this is necessary? Is this a recent change in pnpm? 🤔

ijjk

Hi, this is correct as is and pnpm requires specifying args that should be passed to the subcommand after --. Thanks for the PR though!

## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` x-ref: #37045 x-ref: #37032 x-ref: #36602 x-ref: #36496

This command changed in pnpm [6.32.13](https://github.com/pnpm/pnpm/releases/tag/v6.32.13) and [7.1.1](https://github.com/pnpm/pnpm/releases/tag/v7.1.1) so lets update it since its been a few weeks and we can expect pnpm users to update more regularly than npm users. - Fixes #37240 - Fixes #37045 - Fixes #37032 - Fixes #36602 - Fixes #36496

This command changed in pnpm [6.32.13](https://github.com/pnpm/pnpm/releases/tag/v6.32.13) and [7.1.1](https://github.com/pnpm/pnpm/releases/tag/v7.1.1) so lets update it since its been a few weeks and we can expect pnpm users to update more regularly than npm users. - Fixes vercel/next.js#37240 - Fixes vercel/next.js#37045 - Fixes vercel/next.js#37032 - Fixes vercel/next.js#36602 - Fixes vercel/next.js#36496

fixes pnpm create command (removes extra '--' )

66ddc44

Before: pnpm create next-app -- --typescript After: pnpm create next-app --typescript

rkzofficial requested review from timneutkens, ijjk, shuding, styfle, huozhi, padmaia, leerob and balazsorban44 as code owners April 27, 2022 06:33

ijjk added the area: documentation label Apr 27, 2022

ijjk requested changes Apr 27, 2022

View reviewed changes

ijjk closed this Apr 27, 2022

rkzofficial deleted the patch-1 branch April 28, 2022 10:48

ijjk mentioned this pull request May 19, 2022

Add note clarifying pnpm args handling #37049

Merged

1 task

kodiakhq bot pushed a commit that referenced this pull request May 19, 2022

Add note clarifying pnpm args handling (#37049)

760750d

## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` x-ref: #37045 x-ref: #37032 x-ref: #36602 x-ref: #36496

styfle mentioned this pull request May 27, 2022

Update pnpm create next-app for latest pnpm 6 and 7 #37254

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes pnpm create command (removes extra '--' ) #36496

fixes pnpm create command (removes extra '--' ) #36496

rkzofficial commented Apr 27, 2022 •

edited

Loading

balazsorban44 commented Apr 27, 2022

ijjk left a comment •

edited

Loading

fixes pnpm create command (removes extra '--' ) #36496

fixes pnpm create command (removes extra '--' ) #36496

Conversation

rkzofficial commented Apr 27, 2022 • edited Loading

Bug

Feature

Documentation / Examples

balazsorban44 commented Apr 27, 2022

ijjk left a comment • edited Loading

Choose a reason for hiding this comment

rkzofficial commented Apr 27, 2022 •

edited

Loading

ijjk left a comment •

edited

Loading