Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note clarifying pnpm args handling #37049

Merged
merged 2 commits into from
May 19, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 19, 2022

Documentation / Examples

  • Make sure the linting passes by running yarn lint

x-ref: #37045
x-ref: #37032
x-ref: #36602
x-ref: #36496

@ijjk ijjk marked this pull request as ready for review May 19, 2022 21:58
@balazsorban44
Copy link
Member

See: pnpm/pnpm#4730

@@ -35,7 +35,7 @@ If you want to start with a TypeScript project you can use the `--typescript` fl
npx create-next-app@latest --typescript
# or
yarn create next-app --typescript
# or
# or (the extra '--' is expected and tells pnpm to pass the args down)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove the -- and mention, pnpm 7.1.1

@kodiakhq kodiakhq bot merged commit 760750d into vercel:canary May 19, 2022
@ijjk ijjk deleted the docs/clarify-pnpm-args branch May 19, 2022 22:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants