Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized regression renaming #1120

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Generalized regression renaming #1120

merged 1 commit into from
Oct 11, 2020

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 11, 2020

This PR substitutes 'GIoU' and 'giou' with 'box' throughout YOLOv5. This change is required as we currently use CIoU for box regression criterion rather than GIoU, and using the general term 'box' allows for future changes in the regression criterion without requiring subsequent renaming.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Update loss terminology from GIoU to box for clarity in codebase.

📊 Key Changes

  • Renamed giou loss to box loss across various configuration and code files.
  • Updated comments and logging to reflect the change from GIoU to box.
  • Loss calculation logic now refers to iou loss instead of giou.

🎯 Purpose & Impact

  • Clarifies Loss terminology: Simplifies understanding by using a more generic term box which encompasses different IoU-based loss methods (like CIoU which is actually used).
  • Consistency: Maintains consistency in how loss is referred to within the code, potentially reducing confusion.
  • No Functional Change: The update is predominantly cosmetic, as it does not alter the underlying logic; the functional impact on users is minimal.

@glenn-jocher
Copy link
Member Author

CI tests are passing, will merge.

@glenn-jocher
Copy link
Member Author

BREAKING CHANGE WARNING

Users of earlier/custom hyperparameter files must rename 'giou' field to 'box'.

Screenshot 2020-10-11 at 17 22 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic box loss labels vs GIoU
1 participant