Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic box loss labels vs GIoU #762

Closed
glenn-jocher opened this issue Aug 18, 2020 · 3 comments · Fixed by #1120
Closed

Generic box loss labels vs GIoU #762

glenn-jocher opened this issue Aug 18, 2020 · 3 comments · Fixed by #1120
Assignees
@glenn-jocher
Labels
enhancement New feature or request

Comments

@glenn-jocher
Copy link
Member

glenn-jocher commented Aug 18, 2020 •
edited
Loading

As mentioned in #640 GIoU has been replaced with CIoU.

Best practices here would be to generalize the box regression labels throughout the repo to either 'box' or 'regression' to remove reference to exact criterion used.

TODO: generalize box regression labels throughout repo.
@glenn-jocher glenn-jocher added enhancement New feature or request TODO labels Aug 18, 2020
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 17, 2020
@glenn-jocher glenn-jocher reopened this Oct 11, 2020
@glenn-jocher glenn-jocher mentioned this issue Oct 11, 2020
Closed
@glenn-jocher glenn-jocher self-assigned this Oct 11, 2020
@glenn-jocher
Copy link
Member Author

Will attempt to complete this today. Note that multiple users are now confused by this #640, #1113

@glenn-jocher glenn-jocher linked a pull request Oct 11, 2020 that will close this issue
Generalized regression renaming #1120
Merged
@glenn-jocher
Copy link
Member Author

PR merged, removing TODO label.

@glenn-jocher glenn-jocher removed the TODO label Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glenn-jocher glenn-jocher

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generalized regression renaming ultralytics/yolov5
1 participant
@glenn-jocher