Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cython dependency #640

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Conversation

alexander-pv
Copy link
Collaborator

@alexander-pv alexander-pv commented Jul 17, 2023

Proposed changes

Hi, I noticed that recent Cython builds break causalml package building process.
I added an upper bound for cython version to make everything work as expected.
I also updated Github action versions.

Turned out that an old PR completely rewrote the latest causal_trees_with_synthetic_data.ipynb.
So I returned back conterfactual outcomes example in causal trees notebook.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x ] I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@jeongyoonlee
Copy link
Collaborator

HI @alexander-pv. Can you check if the fix proposed in #642 addresses the build failure with latest Cython? If so, we don't need the Cython version restriction.

@jeongyoonlee
Copy link
Collaborator

Just saw your comment in #534. Please discard my comment above. It looks good to me. Thanks!

@jeongyoonlee jeongyoonlee merged commit 5d43696 into uber:master Jul 19, 2023
6 checks passed
@bsaunders27 bsaunders27 mentioned this pull request Jul 20, 2023
7 tasks
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 22, 2023
* Add cython version upper bound
* Update Github Actions versions
* Return back counterfactual outcomes example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants