-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation updates to README and .github/workflows #637
Conversation
Hi @jeongyoonlee , I was thinking about your comment re the
So as you mentioned, if we can include the above for anything with conda, it probably makes the most sense to move the install |
@jeongyoonlee This PR is ready for an initial review. A brief summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The error for the test-pypi-install.yml
build should have been addressed by #640. Is your branch rebased with the latest master?
I'm not sure what's happening with conda installation tests, though.
Thanks @jeongyoonlee My branch includes #640, and is currently only 1 commit behind master. So I think the error for the PyPI install is still valid. If I understand things correctly, the error arises because it pulls the 0.14.0 release, which doesn't contain the most recent fixes that resolve the build issues: Once a new release is pushed to PyPI, those installations should pass (since the build and tests currently passes). The same thing might be happening for conda-forge- although the conda-forge install is taking a very long time to complete, so there might be another issue there. |
Sounds good. @ras44, why don't we merge this PR and include it in the next v0.14.1 release? |
Proposed changes
This work in progress addresses issues that seem to be arising during installation on cloud instances, in docker, and in google collab.
This PR should help to address #624, #609, #593, #533, #534, and #636 by updating
README.md
and also providing GitHub workflows that confirm build success status for conda-forge, conda-venv, PyPI, and source installations.Types of changes
What types of changes does your code introduce to CausalML?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
This PR contains two elements:
modifications to the
README.md
gcc
andg++
$
from existing code sections to make copy-paste easiernew
.github/workflows
Appreciate your feedback!