Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save and load the draggonnet model #639

Closed
wants to merge 2 commits into from
Closed

Conversation

liudong
Copy link

@liudong liudong commented Jul 14, 2023

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Dong LIU seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@liudong
Copy link
Author

liudong commented Jul 17, 2023

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Dong LIU seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

I have signed the aggreement.

@jeongyoonlee
Copy link
Collaborator

Hi @liudong. Thanks for your contribution!

  1. Can you try to sign CLA again? Please ensure you use the same email address in GitHub when signing CLA.
  2. Can you rebase your code with the latest master, which fixed build and installation issues (see Update Cython dependency #640 and Fix for builds on Mac M1 infrastructure #641), and make sure your builds pass?

Thanks.

@jeongyoonlee jeongyoonlee self-requested a review July 20, 2023 17:08
@jeongyoonlee jeongyoonlee added the enhancement New feature or request label Jul 20, 2023
@ras44
Copy link
Collaborator

ras44 commented Nov 15, 2023

@jeongyoonlee would it help if I resubmitted a PR for this along the lines of what we did in #166 ?

@ras44 ras44 mentioned this pull request Dec 5, 2023
10 tasks
ras44 pushed a commit to ras44/causalml that referenced this pull request Dec 5, 2023
@ras44 ras44 mentioned this pull request Dec 5, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants