Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

3rd-party filter list update: show status/progress indications in UI #965

Closed
chrisaljoudi opened this issue Mar 8, 2015 · 4 comments
Closed

Comments

@chrisaljoudi
Copy link
Contributor

When updating 3rd-party filter lists, it's not uncommon to have one of the servers be down or slow every once in a while. Usually, trying again some time later resolves the issue.

In the current implementation, however, the whole 3rd-party filter list page is "whited out" while the update is in progress. There aren't any individuals indicators next to the filter lists, which creates uncertainty in the user's mind what's going on (has uBlock froze or is the update just not going perfectly?).

It seems like it'd be very helpful to the user to, instead of whiting out the whole page with no status indication, have a "progress bar"/"status text" next to each filter list getting updated.

In that case, for example, if a request times out from one of the servers, one would simply see that error message next to the filter list (remote fetch timed out or something) and try again later.

This will also enable users to see which updates succeed (the status next to the filter would be last updated on 03/08/2015 3:25AM or some such).

@gorhill I'll be going through tomorrow figuring out a plan/general idea on implementing this, but I'd like to hear your opinion.

Some related issues: #719, #376, #860, #964 (probably).

@gorhill
Copy link
Contributor

gorhill commented Mar 8, 2015

I'll be going through tomorrow

I have already work to do in there: #954, + another issue I can't find right now which is about showing the last time a list was updated.

As I say somewhere in here, I work on this project because I like to code.

@chrisaljoudi
Copy link
Contributor Author

@gorhill I understand! If you'd like to work on that, that's completely fine — I just thought I'd offer as to help out with workload.

@Mikey1993
Copy link
Contributor

I support this.
Users often find themselves in a mystery to why is the updating process taking so long.
This disengage users from updating manually their lists regularly for sure.

@chrisaljoudi chrisaljoudi changed the title 3rd-party filter list update "problems" 3rd-party filter list update: show status indications in UI Mar 10, 2015
@chrisaljoudi chrisaljoudi changed the title 3rd-party filter list update: show status indications in UI 3rd-party filter list update: show status/progress indications in UI Mar 10, 2015
@gorhill gorhill added the Fixing label Mar 10, 2015
gorhill added a commit that referenced this issue Mar 11, 2015
@gorhill
Copy link
Contributor

gorhill commented Mar 11, 2015

Fixed in 39ad158.

@gorhill gorhill closed this as completed Mar 11, 2015
@gorhill gorhill removed the Fixing label Mar 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants