Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Can't update filters in Safari #964

Closed
VadimMukhtarov opened this issue Mar 8, 2015 · 20 comments
Closed

Can't update filters in Safari #964

VadimMukhtarov opened this issue Mar 8, 2015 · 20 comments

Comments

@VadimMukhtarov
Copy link

uBlock 0.9.0.0 and previous version can't update filters (EasyList + RU AdList). Just a blue spinning wheel under mouse pointer after pressing the update button. I did permissions repair and reinstalled it, but still doesn't work. I use Safari 8.0.5. With uBlock 0.7.x all was good.

@chrisaljoudi
Copy link
Contributor

@VadimMukhtarov Hi!

Updating filter lists has worked quite reliably, so I couldn't reproduce the issue you described immediately.

t's worth noting: uBlock currently has a 30-second timeout if the remote server isn't responding to your requests.

Is the blue spinning wheel going away after 30 seconds or so? (Might have to wait more than that since multiple lists use the same server). If it is, then the remote server for the list (or your connection) might be having some issues.

Are EasyList and RU AdList the only two filter lists you have enabled?

@VadimMukhtarov
Copy link
Author

Hi. Yes, I use only 2 subscriptions. Just checked with default uBlock settings and got crash with EXC_BAD_ACCESS (SIGSEGV), KERN_INVALID_ADDRESS. And blue wheel spinning again after restart.
Here is crash log http://pastebin.com/7iZhW3Np

@chrisaljoudi
Copy link
Contributor

@VadimMukhtarov hmm. Is the crash still occurring? That error code in the context of Safari crashes seems to sometimes be caused by malware. Do you have "Genieo" installed? That causes the issue for some.

I just installed uBlock on a fresh Safari installation, all the default settings, and I couldn't reproduce the behavior you described.

@chrisaljoudi
Copy link
Contributor

@VadimMukhtarov so, when you're updating the filter lists and you get "stuck" (with the blue beach ball), can you please try + alt/option + c, which will bring up the error console, and see if there's anything there?

Thanks.

@VadimMukhtarov
Copy link
Author

Console is clean, no errors or warnings. And I also 100% don't have any malware.

@chrisaljoudi
Copy link
Contributor

@VadimMukhtarov okay. Did you notice whether the freeze is disappearing after 30-60 seconds?

To help diagnose the issue further:

  • Verify you still can't update the filter lists.
  • Use wget or any other method on your same machine to try and download those two files:
    • http://easylist-downloads.adblockplus.org/easylist.txt <-- this is EasyList.
    • http://easylist-downloads.adblockplus.org/advblock.txt <-- this is RU AdList.

If you can download both of them successfully, but uBlock still freezes the update with just those two enabled, then it's almost certainly not a network issue.

@VadimMukhtarov
Copy link
Author

uBlock finally updated them after Safari restart, but still strange. Got another one crash with the same error. Looks like some regression or incompatibility with Safari 8.0.5.

@chrisaljoudi
Copy link
Contributor

@VadimMukhtarov

Looks like some regression or incompatibility with Safari 8.0.5.

I've been running this version of uBlock on Safari 8.0.5 (my personal machine) for days now — and haven't had a crash.

The reason I mention that is, it's not something that is inherently an obvious incompatibility between uBlock and Safari. There's something that's different between our two machines, and I hope you can help me diagnose that.

What kind of hardware are you facing this issue on? Do you have any guess/idea what seems to "cause" the crash — like, does it crash after you do something specific, or...?

Anything you think might be related would be much appreciated, @VadimMukhtarov.

@VadimMukhtarov
Copy link
Author

@chrisaljoudi I use the latest OS X 10.10.3 from App Store on MPB. All software from App Store and developers websites. No tweaks, plugins and cracks. These problems with uBlock started with 0.8.x branch. It would be nice if it had own log.

@chrisaljoudi
Copy link
Contributor

@VadimMukhtarov any other Safari extensions? (You can check in Safari -> Preferences -> Extensions).

And as far as the problems you mentioned started with 0.8.x, are you talking about the filter list updates, the crashes, or both?

@VadimMukhtarov
Copy link
Author

@chrisaljoudi I have only uBlock. Don't remember exactly about crashes, but problems with saving uBlock settings and filter updates was. Page with settings just stuck.

@gorhill
Copy link
Contributor

gorhill commented Mar 8, 2015

I don't know about the crash, but one thing that could be improved with the manual update (which I try to discourage by the way...) is to fetch lists one by one instead of all at once. Currently it's all at once, and for slow connections this could mean never being able to complete the download of any one list, when many lists are fetched at the same time.

Auto update will fetch the lists one by one, and compile them upon reception, so it is really the optimal way to update the lists.

@chrisaljoudi
Copy link
Contributor

@VadimMukhtarov I'd really like to diagnose this issue and stop the crashes from occurring for you, but I've been trying to trigger one here all day and haven't been able to (including by enabling every

Can you please share the full Safari crash report? Thank you.

@VadimMukhtarov
Copy link
Author

@chrisaljoudi
Copy link
Contributor

@VadimMukhtarov reproduced! I have an idea on what the issue is; will get on it immediately.

FYI: for now, you can avoid the crashes by not updating the filter lists manually so frequently.

Will keep you updated.

@chrisaljoudi
Copy link
Contributor

Merged into #978.

@gorhill
Copy link
Contributor

gorhill commented Mar 10, 2015

What's the issue?

@chrisaljoudi
Copy link
Contributor

@gorhill it's #978 — updating lots of filters quickly ends trying to use up a lot of RAM.

@gorhill
Copy link
Contributor

gorhill commented Mar 10, 2015

Ok, so this confirms pulling one by one with compilation upon reception is the way to go.

@chrisaljoudi
Copy link
Contributor

@gorhill yes, indeed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants