-
Notifications
You must be signed in to change notification settings - Fork 437
Replace instances of innerHTML with Node.cloneNode() #954
Comments
They're referring to this, but that goes through this sanitizer. |
I think I should change it anyway, if only for easier maintenance. That code dates from the early days of HTTPSB. Cloning from a hidden template element in the HTML seems to be a better way to do this. |
Sure. |
Actually, there is another non-trivial use (and thus "inefficient" as per AMO reviewer) of For trivial uses, I will leave them unchanged, since they are sanitized through |
As per Mozilla's preliminary review.
The text was updated successfully, but these errors were encountered: