Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #258 -- subclasses of
pt.Transformer
doesn't passis_transformer
check because it checks forTransformerBase
(a subclass ofTransformer
).This means that you wouldn't be able to use a subclass of
pt.Transformer
in a pipeline. E.g.,Since most code still uses
TransformerBase
, it doesn't break existing code -- just new stuff written using the new name.Added tests that failed with previous impl and added fix.