Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No coerce, pt.Transformer #258

Merged
merged 12 commits into from
Dec 20, 2021
Merged

No coerce, pt.Transformer #258

merged 12 commits into from
Dec 20, 2021

Conversation

cmacdonald
Copy link
Contributor

No description provided.

@cmacdonald cmacdonald added this to the 0.8 milestone Dec 20, 2021
seanmacavaney
seanmacavaney approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@seanmacavaney seanmacavaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, just one minor comment

pyterrier/transformer.py Show resolved Hide resolved
@cmacdonald cmacdonald merged commit 336d0a3 into master Dec 20, 2021
@cmacdonald cmacdonald deleted the no_coerce branch December 20, 2021 21:04
@seanmacavaney seanmacavaney mentioned this pull request Jan 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmacavaney seanmacavaney seanmacavaney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@cmacdonald @seanmacavaney