Skip to content

Commit

Permalink
Merge pull request #274 from seanmacavaney/is_transformer_bug
Browse files Browse the repository at this point in the history
fixed bug with is_transformer
  • Loading branch information
cmacdonald authored Jan 23, 2022
2 parents 070aa59 + 246d5ae commit 8b0465f
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pyterrier/transformer.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def is_function(v):
return isinstance(v, types.FunctionType)

def is_transformer(v):
if isinstance(v, TransformerBase):
if isinstance(v, Transformer):
return True
return False

Expand Down
19 changes: 19 additions & 0 deletions tests/test_transformer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import pyterrier as pt
import unittest
from .base import BaseTestCase
import os
import pandas as pd

class TestTransformer(BaseTestCase):

def test_is_transformer(self):
class MyTransformer1(pt.Transformer):
pass
class MyTransformer2(pt.transformer.TransformerBase):
pass
class MyTransformer3(pt.transformer.IterDictIndexerBase):
pass
class MyTransformer4(pt.transformer.EstimatorBase):
pass
for T in [MyTransformer1, MyTransformer2, MyTransformer3, MyTransformer4]:
self.assertTrue(pt.transformer.is_transformer(T()))

0 comments on commit 8b0465f

Please sign in to comment.