Create e2e suite and replay test #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Mar 28, 2023
robholland
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
I don't think you need to bring this test file in.
feedmeapples
force-pushed
the
replay-test
branch
from
6ea9b39
to
ec7971d
Compare
feedmeapples
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a test to verify
temporal workflow show --output jsonoutputs JSON good for history replayNOTE depends on temporalio/temporal#4026 and temporalio/tctl-kit#40
Why?
verifying
temporalproduces history suitable for replayChecklist
Closes
How was this tested:
added unit test
TestWorkflowShow_ReplayableHistory