Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit urfave writer instead of stdout #40

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Inherit urfave writer instead of stdout #40

merged 1 commit into from
Mar 28, 2023

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Mar 25, 2023 •
edited
Loading

What was changed

Used writer from urfave/cli instead of stdout

Why?

Setting a custom writer can be useful in tests

Checklist

  1. Closes

  2. How was this tested:

updated TestPrintTable_Stdout

  1. Any docs updates needed?

@feedmeapples feedmeapples mentioned this pull request Mar 25, 2023
Merged
@feedmeapples feedmeapples merged commit 577f95d into main Mar 28, 2023
@feedmeapples feedmeapples deleted the inherit-writer branch March 28, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

@bergundy bergundy Awaiting requested review from bergundy

@robholland robholland Awaiting requested review from robholland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feedmeapples @alexshtin