Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create integration tests suite #170

Closed
wants to merge 1 commit into from
Closed

Create integration tests suite #170

wants to merge 1 commit into from

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Mar 25, 2023 •
edited
Loading

What was changed

Create a suite for running integration tests

NOTE depends on temporalio/temporal#4026

Why?

adding integration tests

Checklist

  1. Closes

  2. How was this tested:

tested with History Replay integration test

  1. Any docs updates needed?

@feedmeapples feedmeapples mentioned this pull request Mar 25, 2023
Merged
robholland
robholland reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@robholland robholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to include at least one test which uses the server.

@feedmeapples
Copy link
Contributor Author

sure let's just follow up here with tests #171

@bergundy bergundy deleted the integration-test-suite branch March 29, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robholland robholland robholland left review comments

@bergundy bergundy Awaiting requested review from bergundy

@alexshtin alexshtin Awaiting requested review from alexshtin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feedmeapples @robholland