Add a small delay to tab close on Chrome #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable even though the sleep might not be long enough for some people I suppose. I agree longer term something like a repeat/delay framework as you mentioned in #454 would be nicer. |
michaelpog
pushed a commit
to michaelpog/talon_user
that referenced
this pull request
Aug 31, 2021
Co-authored-by: Xavier Downs <>
daanvdh
pushed a commit
to daanvdh/knausj_talon
that referenced
this pull request
Sep 2, 2021
* master: (55 commits) Added command mode to all language headers to prevent them being active in sleep mode (talonhub#569) Change command client keyboard shortcut (talonhub#572) Make slap command work with Slack (talonhub#535) Add Pound Sterling (£) Sign (talonhub#523) `quote that` and `inside quotes` changes (talonhub#538) Knausj generic terminal establishment (talonhub#514) Add right-drag command to Talon (talonhub#498) Add a small delay to tab close on Chrome (talonhub#553) fix tab jumping for firefox on linux (talonhub#558) implement cancel command properly (talonhub#536) Add a command to copy the url of the current page (talonhub#534) Add fetch all to convenience mappings Update .gitignore Ignore settings directory Delete cancel.talon Fix Mac Terminal Copy-paste (talonhub#525) add phones word/word left/word right commands (talonhub#531) Update switcher.py (talonhub#529) jetbrains filename() quick fix Update switcher.py ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
tab closecommand when repeating across a large number of tabs.Relates to #454.
While this fixes this command for this issue specifically, I'm still supportive of a generic repeat delay framework rather than handling each case individually like this.
For those wondering why there is a wrapper: I had to add an extra layer of abstraction in order to not need to write the specific OS commands (cmd-w vs ctrl-w, etc) while rewriting the function.
Tab.close.demo.mov