Add a command to copy the url of the current page #534
Conversation
apps/generic_browser.talon
Outdated
| @@ -1,6 +1,7 @@ | |||
| tag: browser | |||
| - | |||
| (address bar | go address | go url): browser.focus_address() | |||
| (address copy | url copy | copy address | copy url ): user.address_copy() | |||
There was a problem hiding this comment.
Quite a few different commands here as I try to stay consistent with the existing commands in the file but also meet the desired object -> verb standards
|
This probably doesn't need to be an action; since it will have the same implementation across all browsers so far, you can put it in generic_browser.talon. |
Hmm is this the current stance? I was under the impression we were trying to move implementations away from .talon files. |
|
action implementations in .talon files are deprecated and eventually will stop working, those look like this: But voice commands in .talon files aren't going away, and not every voice command needs to be implemented by a single action. This would be a fairly normal voice command: |
|
I imagine the downside is that this becomes hard to overwrite for specific browsers or to call in another action later? But yep can do if that's preferred 👍 |
…o xdowns/copy-url
…_talon into xdowns/copy-url # Conflicts: # apps/generic_browser.talon
|
@rntz it's now all in .Talon files |
* master: (55 commits) Added command mode to all language headers to prevent them being active in sleep mode (talonhub#569) Change command client keyboard shortcut (talonhub#572) Make slap command work with Slack (talonhub#535) Add Pound Sterling (£) Sign (talonhub#523) `quote that` and `inside quotes` changes (talonhub#538) Knausj generic terminal establishment (talonhub#514) Add right-drag command to Talon (talonhub#498) Add a small delay to tab close on Chrome (talonhub#553) fix tab jumping for firefox on linux (talonhub#558) implement cancel command properly (talonhub#536) Add a command to copy the url of the current page (talonhub#534) Add fetch all to convenience mappings Update .gitignore Ignore settings directory Delete cancel.talon Fix Mac Terminal Copy-paste (talonhub#525) add phones word/word left/word right commands (talonhub#531) Update switcher.py (talonhub#529) jetbrains filename() quick fix Update switcher.py ...
I was finding that this was a really common workflow and wanted to speed it up. I figured others could benefit from it.
This current implementation is just for Chrome, but is generic enough to work with all browsers once we have a shared place to put it. I just didn't want to duplicate it four times without the shared place. For context see (#532).